Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Remove additional indexFields related functions #189706

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Aug 1, 2024

Relates to #180690

Summary

This PR is a follow-up to #189541 and removes additional functions related to the indexFields that are no longer needed

Testing

Check metricIndicesExist and remoteClustersExist in the request by changing the settings (in the first video I use metricbeat and no oblt cluster and in the second one I am connected to oblt cluster)

no_cluster.mov
with_remote_cluster.mov

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Aug 1, 2024
@jennypavlova jennypavlova self-assigned this Aug 1, 2024
@jennypavlova
Copy link
Member Author

/ci

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova jennypavlova marked this pull request as ready for review August 1, 2024 10:55
@jennypavlova jennypavlova requested review from a team as code owners August 1, 2024 10:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

before this change:

image

After:
image

Source endpoint response size will now be stable, not being affected by the number of fields the indices have, and small

Thanks for this change!

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 1, 2024
@jennypavlova jennypavlova merged commit a18d60c into elastic:main Aug 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants