[Fleet] Allow to move agent policy to another space.#189663
Merged
nchaulet merged 16 commits intoelastic:mainfrom Aug 15, 2024
Merged
[Fleet] Allow to move agent policy to another space.#189663nchaulet merged 16 commits intoelastic:mainfrom
nchaulet merged 16 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
force-pushed
the
feature-move-agent-policy-space
branch
from
3b3fdb5 to
85f4405
Compare
Merged
5 tasks
nchaulet
force-pushed
the
feature-move-agent-policy-space
branch
from
687c622 to
0fda816
Compare
nchaulet
commented
Aug 9, 2024
| indexPattern: INGEST_SAVED_OBJECT_INDEX, | ||
| hidden: false, | ||
| namespaceType: useSpaceAwareness ? 'single' : 'agnostic', | ||
| namespaceType: useSpaceAwareness ? 'multiple' : 'agnostic', // TEMP multiple until we address TODO |
Member
Author
There was a problem hiding this comment.
Tmp until this is merged #189387 same for bellow
nchaulet
added
release_note:skip
Member
Author
|
/ci |
nchaulet
force-pushed
the
feature-move-agent-policy-space
branch
from
2aec574 to
f2592ec
Compare
Member
Author
|
/ci |
nchaulet
force-pushed
the
feature-move-agent-policy-space
branch
from
3e5dd04 to
6689e9c
Compare
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
paul-tavares
approved these changes
Aug 13, 2024
Contributor
paul-tavares
left a comment
paul-tavares
left a comment
There was a problem hiding this comment.
Changes under Security Solution look good 👍
thanks.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #182733
Test are failing as it need 189387 to be merged but the PR should be ready for a first pass of review.
#189387 should be merged before (to be able to use
updateObjectsSpacessaved object must be multiple.)API changes
The update agent policy API now accept a
space_idsproperty, when space change, we update the policy saved object (agent policy and package policy). Then we update the related Fleet system indices enrollment tokens and agents.We only allow to change the spaces to space where the has the
AgentPolicies:Allprivileges.Introduce a new internal API that return the space a user has access with
AgentPolicies:AllUI Changes
Todo
Test
With space awareness enabled (
useSpaceAwarenessfeature flag)