Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] BedrockChat & GeminiChat (#186809) #189008

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

stephmilovic
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

## Summary

Adopted `BedrockChat` from `@langchain/community` package that adds
support for tools calling
https://js.langchain.com/v0.2/docs/integrations/chat/bedrock/

Adopted `ChatGoogleGenerativeAI ` from `@langchain/google-genai` package
that adds support for tools calling
https://js.langchain.com/v0.2/docs/integrations/chat/google_generativeai

Hidden behind FF:
`--xpack.securitySolution.enableExperimental=[assistantBedrockChat]`

As of this PR `integration_assistant` is still going to use
`ActionsClientSimpleChatModel`. After the FF will be enabled by default
we will switch `integration_assistant` to use new chat model.

Thank you @stephmilovic a ton 🙇

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Steph Milovic <[email protected]>
Co-authored-by: Garrett Spong <[email protected]>
(cherry picked from commit 26dd61e)

# Conflicts:
#	package.json
#	yarn.lock
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationAssistant 536 539 +3
securitySolution 5613 5616 +3
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +4.2KB
integrationAssistant 933.2KB 937.4KB +4.2KB
securitySolution 17.2MB 17.2MB +4.5KB
total +12.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/langchain 3 1 -2
elasticAssistant 1 2 +1
total -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 86.4KB 86.4KB +24.0B
stackConnectors 53.6KB 53.7KB +60.0B
timelines 109.3KB 113.4KB +4.2KB
total +4.3KB
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/langchain 0 1 +1

Total ESLint disabled count

id before after diff
@kbn/langchain 0 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit aa450a4 into elastic:8.15 Jul 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants