Skip to content

Upgrade EUI to v95.4.0#188865

Merged
cee-chen merged 5 commits intoelastic:mainfrom
mgadewoll:eui/version-95.4.0
Jul 25, 2024
Merged

Upgrade EUI to v95.4.0#188865
cee-chen merged 5 commits intoelastic:mainfrom
mgadewoll:eui/version-95.4.0

Conversation

@mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Jul 22, 2024 •
edited
Loading

v95.3.0 ⏩ v95.4.0

Questions? Please see our Kibana upgrade FAQ.

v95.4.0

  • Added anomalyChart, anomalySwimLane, changePointDetection, fieldStatistics, logPatternAnalysis, logRateAnalysis and singleMetricViewer glyph to EuiIcon (#7873)

Bug fixes

  • Fixed overlapping content in EuiBasicTable for expanded and selectable table rows (#7895)
  • Fixed the alignment of EuiBasicTable mobile actions (#7895)

Accessibility

  • Improved EuiStat's screen reader accessibility (#7864)

Additional Changes

  • reverts temporary fix for overlapping content in nested tables done in PR #188374

@mgadewoll mgadewoll added release_note:skip Skip the PR/issue when compiling release notes EUI v8.16.0 labels Jul 22, 2024
@mgadewoll
Copy link
Contributor Author

mgadewoll commented Jul 23, 2024

/ci

@mgadewoll mgadewoll marked this pull request as ready for review July 23, 2024 16:55
@mgadewoll mgadewoll requested review from a team as code owners July 23, 2024 16:55
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 23, 2024

Pinging @elastic/eui-team (EUI)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jul 23, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 23, 2024

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@walterra
Copy link
Contributor

walterra commented Jul 23, 2024 •
edited
Loading

Regarding the fixes for overlapping content in nested tables, it would be great if you could include a git revert caa56862de1905a7e62cb2fffb92ced06fd8dc23 in this PR so it will undo the temporary fix we merged in #188374

dominiqueclarke
dominiqueclarke approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgadewoll
Copy link
Contributor Author

mgadewoll commented Jul 24, 2024

Regarding the fixes for overlapping content in nested tables, it would be great if you could include a git revert caa56862de1905a7e62cb2fffb92ced06fd8dc23 in this PR so it will undo the temporary fix we merged in #188374

@walterra I didn't do a git revert but a manual revert in this commit as I talked to @alvarezmelissa87 and a) the icon type changes should stay and b) we could already move to use euiTheme instead of theme anyway. But let me know if you prefer a hard git revert instead

@walterra
Copy link
Contributor

walterra commented Jul 24, 2024

@mgadewoll, great, I missed you both were already on top of this! 👍

adcoelho
adcoelho approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes ok 👍

@mgadewoll
Copy link
Contributor Author

mgadewoll commented Jul 25, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented Jul 25, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.0MB 3.0MB -1.0B
ml 4.6MB 4.6MB +96.0B
observability 420.6KB 420.6KB +34.0B
transform 632.7KB 632.6KB -67.0B
total +62.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.0MB 6.0MB +24.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@cee-chen cee-chen merged commit 2295ba1 into elastic:main Jul 25, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adcoelho adcoelho adcoelho approved these changes

@crespocarlos crespocarlos crespocarlos approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@semd semd semd approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project EUI release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.