[ftr] add lost APM stateful configs#188825
Merged
dmlemeshko merged 1 commit intoelastic:mainfrom Jul 22, 2024
Merged
Conversation
Contributor
Author
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
dmlemeshko
added
v8.15.0
release_note:skip
jbudz
approved these changes
Jul 22, 2024
dmlemeshko
added a commit
that referenced
this pull request
Jul 22, 2024
## Summary Follow-up to #188825 @crespocarlos reported that some Oblt configs after missing after #187440 I was using `node scripts/check_ftr_configs.js` to validate I did not miss anything and decided to debug the script. We had a pretty strict config file content validation like `testRunner|testFiles`, that was skipping some FTR configs like `x-pack/test/apm_api_integration/basic/config.ts` I extended file content check to look for default export function and also skip test/suite or Cypress-own config files. In the end 7 FTR configs were discovered, but only 2 are with tests. I will ask owners to confirm if it should be enabled/disabled. Script run output: ``` node scripts/check_ftr_configs.js ERROR The following files look like FTR configs which are not listed in one of manifest files: - x-pack/plugins/observability_solution/uptime/e2e/config.ts - x-pack/test/functional_basic/apps/ml/config.base.ts - x-pack/test/functional_basic/apps/transform/config.base.ts - x-pack/test/security_solution_api_integration/config/ess/config.base.trial.ts - x-pack/test_serverless/functional/test_suites/observability/cypress/oblt_config.base.ts Make sure to add your new FTR config to the correct manifest file. Stateful tests: .buildkite/ftr_platform_stateful_configs.yml .buildkite/ftr_oblt_stateful_configs.yml .buildkite/ftr_security_stateful_configs.yml .buildkite/ftr_search_stateful_configs.yml Serverless tests: .buildkite/ftr_base_serverless_configs.yml .buildkite/ftr_oblt_serverless_configs.yml .buildkite/ftr_security_serverless_configs.yml .buildkite/ftr_search_serverless_configs.yml ERROR Please add the listed paths to the correct manifest file. If it's not an FTR config, you can add it to the IGNORED_PATHS in packages/kbn-test/src/functional_test_runner/lib/config/run_check_ftr_configs_cli.ts or contact #kibana-operations ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During #187440 we lost some FTR configs, this PR adds it back.