[ObsUX][APM] Rename observability setting `apmEnableMultiSignal` to `entityCentricExperience` by jennypavlova · Pull Request #188097 · elastic/kibana

jennypavlova · 2024-07-11T11:58:31Z

Closes https://github.com/elastic/observability-dev/issues/3731

Summary

This PR rename apmEnableMultiSignal to entityCentricExperience

elasticmachine · 2024-07-11T11:58:33Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine · 2024-07-11T11:58:38Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

obltmachine · 2024-07-11T11:58:46Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

bmorelli25

On the documentation side, please take a look at our config docs and make sure there are no changes or entries needed. Thanks! Approving to unblock.

dominiqueclarke

It seems like users who have previously opted into apmEnableMultiSignal will need to re-opt into the new setting. Is that intended?

jennypavlova · 2024-07-11T16:20:55Z

It seems like users who have previously opted into apmEnableMultiSignal will need to re-opt into the new setting. Is that intended?

My understanding is that we want to replace this flag and as this is a new feature it should be fine to have the new flag instead (and ignore the old one). @roshan-elastic is that correct?

I think it will make sense to backport it to 8.15 as this flag has not been released yet and we can have it there with the new name directly

roshan-elastic · 2024-07-11T16:25:48Z

My understanding is that we want to replace this flag and as this is a new feature it should be fine to have the new flag instead (and ignore the old one). @roshan-elastic is that correct?

I think it will make sense to backport it to 8.15 as this flag has not been released yet and we can have it there with the new name directly

Yeah @jennypavlova - that's right. The existing feature flag was off by default and it's unlikely anyone ever found it (it was only in stack management). Even if they turned it on, it wouldn't have really done anything. When I tested, it basically just made APM blank (presumably it was work in progress still).

dominiqueclarke

LGTM

smith · 2024-07-11T23:48:20Z

Changing it isn't a problem like Roshan said, but it recommended to migrate them. I don't think it's necessary here.

crespocarlos

LGTM!

There are still a few things besides this setting named "multi signal". Are we planning on renaming those too?

jennypavlova · 2024-07-12T08:48:50Z

There are still a few things besides this setting named "multi signal". Are we planning on renaming those too?

@crespocarlos As mentioned here we are renaming it because we will include multiple experiences under the same feature flag, IMO multi signal is still valid for the component names, please let me know if you think otherwise.

crespocarlos · 2024-07-12T08:51:54Z

@crespocarlos As mentioned here we are renaming it because we will include multiple experiences under the same feature flag, IMO multi signal is still valid for the component names, please let me know if you think otherwise.

Yeah. multi signal makes sense as you said. Thanks!

jennypavlova · 2024-07-12T10:09:33Z

On the documentation side, please take a look at our config docs and make sure there are no changes or entries needed. Thanks! Approving to unblock.

@bmorelli25 The feature flag was not there before I renamed it so I can confirm that I didn't change anything there. I guess we don't need any changes there in this case, right?

cauemarcondes · 2024-07-15T12:26:05Z

x-pack/plugins/observability_solution/observability/server/ui_settings.ts

-      defaultMessage:
-        '{technicalPreviewLabel} Enable the multi-signal feature in APM, which allows you to monitor services from logs and traces.',
+    description: i18n.translate('xpack.observability.entityCentricExperienceDescription', {
+      defaultMessage: '{technicalPreviewLabel} Promote entity-centric experience to users.',


Can we add a better description here? It doesn't say much more than the title itself. Maybe @mdbirnstiehl could help?!

cc: @roshan-elastic

kibanamachine · 2024-07-15T16:46:45Z

💔 All backports failed

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts
❌	8.15	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 188097

Questions ?

Please refer to the Backport tool documentation

jennypavlova · 2024-07-15T17:05:42Z

💚 All backports created successfully

Status	Branch	Result
✅	8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…entityCentricExperience` (elastic#188097) Closes elastic/observability-dev#3731 ## Summary This PR rename `apmEnableMultiSignal` to `entityCentricExperience` <img width="1834" alt="image" src="https://github.com/elastic/kibana/assets/14139027/bc8dfcf6-f739-4215-9f68-47345fbdef5e"> Co-authored-by: Katerina <aikaterini.patticha@elastic.co> (cherry picked from commit 9291a4f) # Conflicts: # packages/kbn-management/settings/setting_ids/index.ts

kibanamachine · 2024-09-03T21:48:59Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2024-09-30T14:48:09Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2024-09-30T14:48:10Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2024-09-30T22:15:31Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11114971159

kibanamachine · 2024-09-30T22:19:50Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 188097

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2024-10-01T08:22:18Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11121442959

kibanamachine · 2024-10-01T08:26:37Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 188097

Questions ?

Please refer to the Backport tool documentation

afharo · 2024-10-01T08:29:32Z

Based on this comment, I'll switch this PR to backport:skip

Rename apmEnableMultiSignal to entityCentricExperience

1e6a7c1

jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Jul 11, 2024

jennypavlova self-assigned this Jul 11, 2024

jennypavlova requested review from a team as code owners July 11, 2024 11:58

jennypavlova requested a review from a team July 11, 2024 11:58

botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jul 11, 2024

bmorelli25 approved these changes Jul 11, 2024

View reviewed changes

dominiqueclarke reviewed Jul 11, 2024

View reviewed changes

ElenaStoeva approved these changes Jul 11, 2024

View reviewed changes

jennypavlova added backport:all-open Backport to all branches that could still receive a release and removed backport:skip This PR does not require backporting labels Jul 11, 2024

dominiqueclarke approved these changes Jul 11, 2024

View reviewed changes

crespocarlos approved these changes Jul 12, 2024

View reviewed changes

cauemarcondes reviewed Jul 15, 2024

View reviewed changes

Dosant approved these changes Jul 15, 2024

View reviewed changes

rudolf approved these changes Jul 15, 2024

View reviewed changes

afharo approved these changes Jul 15, 2024

View reviewed changes

jennypavlova merged commit 9291a4f into elastic:main Jul 15, 2024

kibanamachine added the v8.16.0 label Jul 15, 2024

jennypavlova mentioned this pull request Jul 15, 2024

[8.15] [ObsUX][APM] Rename observability setting apmEnableMultiSignal to entityCentricExperience (#188097) #188335

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 3, 2024

kibanamachine mentioned this pull request Sep 23, 2024

[APM] Use excluded data tiers setting #192373

Merged

smith added backport:prev-minor and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:all-open Backport to all branches that could still receive a release labels Sep 30, 2024

kibanamachine added the v9.0.0 label Sep 30, 2024

afharo added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 1, 2024

afharo removed the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 1, 2024

afharo assigned jennypavlova and unassigned jennypavlova Oct 1, 2024

afharo added backport:skip This PR does not require backporting and removed backport:prev-minor labels Oct 1, 2024

Conversation

jennypavlova commented Jul 11, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jul 11, 2024

Uh oh!

elasticmachine commented Jul 11, 2024

Uh oh!

obltmachine commented Jul 11, 2024

🤖 GitHub comments

Uh oh!

bmorelli25 left a comment

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke left a comment

Choose a reason for hiding this comment

Uh oh!

jennypavlova commented Jul 11, 2024

Uh oh!

roshan-elastic commented Jul 11, 2024

Uh oh!

dominiqueclarke left a comment

Choose a reason for hiding this comment

Uh oh!

smith commented Jul 11, 2024

Uh oh!

crespocarlos left a comment

Choose a reason for hiding this comment

Uh oh!

jennypavlova commented Jul 12, 2024

Uh oh!

crespocarlos commented Jul 12, 2024

Uh oh!

jennypavlova commented Jul 12, 2024

Uh oh!

cauemarcondes Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jennypavlova Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jul 15, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

jennypavlova commented Jul 15, 2024

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Sep 3, 2024

Uh oh!

kibanamachine commented Sep 30, 2024

Uh oh!

kibanamachine commented Sep 30, 2024

Uh oh!

kibanamachine commented Sep 30, 2024

Uh oh!

kibanamachine commented Sep 30, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Oct 1, 2024

Uh oh!

kibanamachine commented Oct 1, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

afharo commented Oct 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

jennypavlova commented Jul 11, 2024 •

edited by kibanamachine

Loading

cauemarcondes Jul 15, 2024 •

edited

Loading