fix: [Obs Inventory][KEYBOARD]: The map view tooltips must be available on keyboard focus#187861
fix: [Obs Inventory][KEYBOARD]: The map view tooltips must be available on keyboard focus#187861alexwizp merged 5 commits intoelastic:mainfrom
Conversation
|
/ci |
|
/ci |
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
jennypavlova
left a comment
There was a problem hiding this comment.
Thank you for adding that! The keyboard navigation works as expected 🎉
I found other issues/regressions while testing it (mentioned in the comments). Please let me know if you need help reproducing/understanding the issues.
There was a problem hiding this comment.
Q: Is this div needed? Should we remove it?
There was a problem hiding this comment.
The EUI tooltip is not displayed when navigating with the keyboard without this wrapper. I have not found a way to solve this problem
There was a problem hiding this comment.
I am also not sure maybe we can check with @elastic/eui-team. It's not blocking for the PR.
.../observability_solution/infra/public/pages/metrics/inventory_view/components/waffle/node.tsx
Outdated
Show resolved
Hide resolved
...ability_solution/infra/public/pages/metrics/inventory_view/components/waffle/node_square.tsx
Outdated
Show resolved
Hide resolved
|
@jennypavlova thank you for your review. I temporary moved it to |
…le on keyboard focus
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jennypavlova
left a comment
There was a problem hiding this comment.
LGTM 💯 Thanks for the fixes!
Closes: https://github.com/elastic/observability-accessibility/issues/43
Closes: https://github.com/elastic/observability-accessibility/issues/18
Description
https://github.com/elastic/observability-accessibility/issues/43: The Observability Inventory map view has a grid of map tiles that each accept a mouse event to show a tooltip. This tooltip must also be available when the tile receives keyboard focus.
https://github.com/elastic/observability-accessibility/issues/18: The Inventory > Kubernetes Pods popover stays open when I click "Create Inventory Rule" and the modal dialog opens. This creates an odd stacking order and obscures content for users at smaller viewport width.
Steps to recreate
Screens
Screen.Recording.2024-08-21.at.16.03.06.mov
Screen.Recording.2024-08-21.at.16.02.04.mov