Skip to content

fix: [Obs Inventory][KEYBOARD]: The map view tooltips must be available on keyboard focus#187861

Merged
alexwizp merged 5 commits intoelastic:mainfrom
alexwizp:k8s-focus
Aug 22, 2024
Merged

fix: [Obs Inventory][KEYBOARD]: The map view tooltips must be available on keyboard focus#187861
alexwizp merged 5 commits intoelastic:mainfrom
alexwizp:k8s-focus

Conversation

@alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jul 9, 2024

Closes: https://github.com/elastic/observability-accessibility/issues/43
Closes: https://github.com/elastic/observability-accessibility/issues/18

Description

Steps to recreate

  1. Open Inventory Hosts map view
  2. Change Hosts to Kubernetes Clusters
  3. Try to select specific node using the keyboard

Screens

Screen.Recording.2024-08-21.at.16.03.06.mov
Screen.Recording.2024-08-21.at.16.02.04.mov

@alexwizp
Copy link
Contributor Author

alexwizp commented Jul 9, 2024

/ci

@alexwizp alexwizp added v8.16.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Accessibility labels Jul 9, 2024
@alexwizp
Copy link
Contributor Author

alexwizp commented Jul 9, 2024

/ci

@alexwizp alexwizp marked this pull request as ready for review July 9, 2024 18:30
@alexwizp alexwizp requested a review from a team July 9, 2024 18:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 9, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 15, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB +196.0B

History

  • 💚 Build #221052 succeeded 0b21fe4cbe7269527a62bde601dbb2278f83715a
  • 💚 Build #220447 succeeded 4f0735b42344b555ab8f81c14a28d52fcc6f80df
  • 💛 Build #220381 was flaky 4500b849c7d6ba7574e7748f0d094d803e96d0c0
  • 💔 Build #220361 failed 567d399530ed83e8399fe452189dc93809579f53

@jennypavlova jennypavlova self-requested a review July 15, 2024 09:40
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding that! The keyboard navigation works as expected 🎉
I found other issues/regressions while testing it (mentioned in the comments). Please let me know if you need help reproducing/understanding the issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is this div needed? Should we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EUI tooltip is not displayed when navigating with the keyboard without this wrapper. I have not found a way to solve this problem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also not sure maybe we can check with @elastic/eui-team. It's not blocking for the PR.

@alexwizp alexwizp marked this pull request as draft July 15, 2024 16:41
@alexwizp
Copy link
Contributor Author

@jennypavlova thank you for your review. I temporary moved it to Draft to fix your comments.

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp marked this pull request as ready for review August 21, 2024 16:28
@alexwizp alexwizp requested a review from jennypavlova August 21, 2024 16:28
@kibana-ci
Copy link

kibana-ci commented Aug 21, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: ae09ef0
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-187861-ae09ef0af482

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #76 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Prebuilt Rules status get_prebuilt_rules_status should return empty structure when no prebuilt rule assets
  • [job] [logs] FTR Configs #84 / Visualizations - Group 3 lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB -150.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Thanks for the fixes!

@alexwizp alexwizp merged commit e782811 into elastic:main Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:review backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants