Skip to content

[Security Solution] Integrates security solution tests with Kibana QA quality gate#187266

Merged
MadameSheema merged 13 commits intoelastic:mainfrom
MadameSheema:2nd-QG
Aug 29, 2024
Merged

[Security Solution] Integrates security solution tests with Kibana QA quality gate#187266
MadameSheema merged 13 commits intoelastic:mainfrom
MadameSheema:2nd-QG

Conversation

@MadameSheema
Copy link
Contributor

@MadameSheema MadameSheema commented Jul 1, 2024

Summary

Once this PR is merged, when the Kibana QA quality gate is triggered the following tests are going to be executed:

  • API tests tagged with @serverlessQA
  • Cypress tests tagged with @serverlessQA

Currently there are only a few that have been extensively tested and are passing on MKI environments.

The current and future tests:

  • Cover critical paths of the Security Solution application
  • Test behaviours that if broken SDH or blocker issues might be reported by customers.

We have created a run book that has been shared with all the team members of Security Solution and can be found in our internal docs with the title Security Serverless Kibana QA Quality Gate Failure Run Book

Some of the most important points mentioned in the run book:

Below are the channels/groups to be contacted should a test fail:

  • Detection Engine tests:

    • #security-detection-engine
    • @security-detection-engine-team
  • Entity Analytics tests:

    • #security-entity-analytics
    • @security-entity-analytics-team
  • Explore tests:

    • #threat-hunting-explore
    • @security-threat-hunting-explore
  • Investigations tests:

    • #security-threat-hunting-investigations
    • @threat-hunting-investigations
  • Gen AI tests:

    • #security-gen-ai-sharing
    • @security-generative-ai-team
  • Rule Management tests:

    • #security-detection-rule-management
    • @security-detection-rule-management-team
  • Defend Workflows tests:

    • #security-defend-workflows
    • @defend-workflows
  • Geneve detection rules tests:

    • #sec-eng-productivity
    • @sec-eng-prod & @Dom

If nobody responds within 30 minutes: Post the issue in the #security-unified-app channel with the message that team X is not responding and assistance is needed. Tag @sec-eng-prod as well.

Should a failure occur, the Release Manager (RM) will post in the team channell and @ the team responsible. The team, unless in the middle of responding to an SDH Sev1-2, must respond immediately and begin investigation with the RM. Serverless test failures in the Production Quality Release Pipeline are BLOCKING for the entire Kibana Serverless release.

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0 labels Jul 1, 2024
@MadameSheema MadameSheema self-assigned this Jul 1, 2024
@MadameSheema MadameSheema requested a review from a team as a code owner July 1, 2024 15:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema requested review from dkirchan and pheyos July 1, 2024 15:15
jbudz
jbudz previously approved these changes Jul 1, 2024
@jbudz jbudz dismissed their stale review July 1, 2024 15:34

discussing

@MadameSheema
Copy link
Contributor Author

Any update on this @pheyos @jbudz ?

@pheyos
Copy link
Member

pheyos commented Jul 3, 2024

@MadameSheema we're discussing things async. Will come back here once we have a agreement.

MadameSheema added a commit that referenced this pull request Jul 4, 2024
…our QGs (#187389)

## Summary

The Threat Hunting API tests are not part of our QGs, in this PR we are
adding them to it.

Once this PR is merged:

- All the API tests marked as `@serverless` are going to be executed as
part of the periodic pipeline
- Once this other [PR](#187266) is
merged, all the API tests marked as `@serverlessQA` will be executed as
part of the Kibana QA QG (second quality gate).

---------

Co-authored-by: dkirchan <diamantis.kirchantzoglou@elastic.co>
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @MadameSheema

@MadameSheema
Copy link
Contributor Author

@jbudz @pheyos we have a full week of green results on the tests tagged to be executed as part of the kibana QA quality gate

@jbudz
Copy link
Contributor

jbudz commented Aug 7, 2024

@jbudz @pheyos we have a full week of green results on the tests tagged to be executed as part of the kibana QA quality gate

@lukeelmers is taking lead on approving

@pheyos
Copy link
Member

pheyos commented Aug 23, 2024

I've checked the pipeline and started a slack discussion with @MadameSheema.

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussed criteria for the quality gate addition are sufficiently met. There are a few follow-up items on the list, which should be addressed near-term, but this is not blocking here.

build:
env:
ENVIRONMENT: ${ENVIRONMENT}
message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-qa.yaml)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is off

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 7d54e4e into elastic:main Aug 29, 2024
@MadameSheema MadameSheema deleted the 2nd-QG branch August 29, 2024 14:45
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants