[Investigations] - Add timeline api codegen #187172
Conversation
michaelolo24
added
the
Team:Threat Hunting:Investigations
| @@ -25,6 +25,8 @@ | |||
| {{~else~}} | |||
| .merge({{> zod_schema_item }}) | |||
| {{~/if~}} | |||
| {{~#if ../nullable}}.nullable(){{/if~}} | |||
There was a problem hiding this comment.
Needed to update based on how nullable: true interacts with the $ref. Reference Issue
There was a problem hiding this comment.
@michaelolo24 is this something you consider a blocker for this PR?
There was a problem hiding this comment.
Oh, I updated this, so it was more of a note. Updated the text from Need => Needed as it was done :)
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
michaelolo24
added
release_note:skip
|
/ci |
|
/ci |
|
@michaelolo24 I'm getting a bunch of linter errors:
Which config did you use when you ran spectral? I used the ones linked from the docs: https://github.com/elastic/elastic-openapi/blob/main/.spectral.yaml |
| @@ -39,9 +39,9 @@ paths: | |||
| type: object | |||
| properties: | |||
| getOneTimeline: | |||
| oneOf: | |||
There was a problem hiding this comment.
@janmonschke this is why the handlebars template needed to be updated. The old pattern here wasn't valid in the 3.0.0 schema. We'll need to change it if we update it if we ever change our schema
|
|
||
| export type PinnedEvent = z.infer<typeof PinnedEvent>; | ||
| export const PinnedEvent = z.object({ | ||
| columns: ColumnHeaderResult.optional(), |
There was a problem hiding this comment.
This shouldn't be here
|
Closing as the necessary changes were ported here |
Summary
Epic: https://github.com/elastic/security-team/issues/9400
Introduce automatic zod schema generation of api's based on open api spec.
Testing:
yarn openapi:generate