Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add prebuiltRulesCustomizationEnabled feature flag #186823

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[Security Solution] Add prebuiltRulesCustomizationEnabled feature flag #186823

merged 1 commit into from
Jun 24, 2024

Conversation

nikitaindik
Copy link
Contributor

@nikitaindik nikitaindik commented Jun 24, 2024 •
edited
Loading

Resolves: #180130

Summary

This PR adds a prebuiltRulesCustomizationEnabled feature flag.

It unblocks working on the tickets under Changes hidden behind the feature flag in the prebuilt rules customization epic.

@nikitaindik nikitaindik added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules v8.15.0 labels Jun 24, 2024
@nikitaindik nikitaindik self-assigned this Jun 24, 2024
@nikitaindik nikitaindik requested a review from a team as a code owner June 24, 2024 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #48 / Cloud Security Posture Test adding Cloud Security Posture Integrations KSPM EKS KSPM EKS Assume Role KSPM EKS Assume Role workflow

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 84.4KB 84.5KB +37.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nikitaindik

@nikitaindik nikitaindik merged commit 87be241 into elastic:main Jun 24, 2024
55 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 24, 2024
@banderror banderror mentioned this pull request Jun 26, 2024
Merged
banderror added a commit that referenced this pull request Jun 26, 2024
@banderror
[Security Solution] Fix prebuiltRulesCustomizationEnabled feature f…
34f76ad 
…lag (#186964)

**Resolves: #180130
**Follow-up to:** #186823

## Summary

- Adds more information to the feature flag's JSDoc comment according to
the template we use for feature flags.
- Changes the ticket's link to a public one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcrzx xcrzx xcrzx approved these changes

Assignees

@nikitaindik nikitaindik

Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Add a new feature flag prebuiltRulesCustomizationEnabled
5 participants
@nikitaindik @elasticmachine @kibana-ci @xcrzx @kibanamachine