[Shared UX Router Component] Fix context implementation by rshen91 · Pull Request #186532 · elastic/kibana

rshen91 · 2024-06-20T14:01:44Z

Summary

Issue raised in team slack. The pageName in the execution context remains the same on every route change. This component is not widely used so this was not caught until June 19.

I'm not sure if we should have this component since it might be dated - but open to discussion. Based on an initial look, it seems that many other places in code are using react-router vs this component and that might be a preferred alternative.

Main issue - there is a circular dependency that can be seen in core_system.ts. application is instantiated and then it's value is used for the kibana execution context. I'm not sure if the path forward is to change the dependencies of the Router to not need the execution context...or to move the Router out of the application and have it in chrome?

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

rshen91 · 2024-07-25T23:14:02Z

/ci

…fix'

rshen91 · 2024-07-26T15:18:49Z

/ci

…fix'

rshen91 · 2024-07-26T16:44:38Z

/ci

kibana-ci · 2024-07-26T17:12:14Z

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #82 / [Essentials PLI] Test Cloud Security Posture Integrations on Serverless "before all" hook for "[Essentials PLI] Integration installation form should be available with Essentials or Complete PLI"
[job] [logs] Jest Tests #13 / on component mount should show a loading indicator on component
[job] [logs] Jest Tests #13 / when there are auto-follow patterns detail panel should have a "settings" section
[job] [logs] Jest Tests #13 / when there are auto-follow patterns detail panel should have a default value when there are no prefix or no suffix
[job] [logs] Jest Tests #13 / when there are auto-follow patterns detail panel should open a detail panel when clicking on an auto-follow pattern
[job] [logs] Jest Tests #13 / when there are auto-follow patterns detail panel should set the correct auto-follow pattern settings values
[job] [logs] Jest Tests #13 / when there are auto-follow patterns detail panel should set the title the auto-follow pattern that has been selected
[job] [logs] Jest Tests #13 / when there are auto-follow patterns detail panel should show a preview of the indices that might be generated by the auto-follow pattern
[job] [logs] Jest Tests #13 / when there are auto-follow patterns manage patterns context menu button should be visible when an auto-follow pattern is selected
[job] [logs] Jest Tests #13 / when there are auto-follow patterns manage patterns context menu button should open a confirmation modal when clicking the delete button
[job] [logs] Jest Tests #13 / when there are auto-follow patterns manage patterns context menu button should remove the auto-follow pattern from the table after delete is complete
[job] [logs] Jest Tests #13 / when there are auto-follow patterns manage patterns context menu button should update the button label according to the number of patterns selected
[job] [logs] Jest Tests #13 / when there are auto-follow patterns should have a button to create an auto-follow pattern
[job] [logs] Jest Tests #13 / when there are auto-follow patterns should list the auto-follow patterns in the table
[job] [logs] Jest Tests #13 / when there are auto-follow patterns should not display the empty prompt
[job] [logs] Jest Tests #13 / when there are auto-follow patterns table row actions should have a "pause", "delete" and "edit" action button on each row
[job] [logs] Jest Tests #13 / when there are auto-follow patterns table row actions should open a confirmation modal when clicking on "delete" button
[job] [logs] Jest Tests #13 / when there are multiple pages of auto-follow patterns pagination works
[job] [logs] Jest Tests #13 / when there are multiple pages of auto-follow patterns search works
[job] [logs] Jest Tests #13 / when there are no auto-follow patterns should display an empty prompt
[job] [logs] Jest Tests #13 / when there are no auto-follow patterns should have a button to create a follower index
[job] [logs] FTR Configs #75 / a11y tests using flights sample data "after all" hook in "using flights sample data"
[job] [logs] FTR Configs #75 / a11y tests using flights sample data "before all" hook in "using flights sample data"
[job] [logs] FTR Configs #74 / Actions and Triggers app Home page Loads the app with limited privileges Loads the Alerts page
[job] [logs] FTR Configs #82 / Advanced Settings security feature controls global advanced_settings all privileges "after all" hook for "doesn't show read-only badge"
[job] [logs] FTR Configs #82 / Advanced Settings security feature controls global advanced_settings all privileges "before all" hook for "shows management navlink"
[job] [logs] FTR Configs #45 / analytics analytics service analytics service: public side "before all" hook for "should see both events enqueued and sent to the shipper"
[job] [logs] FTR Configs #69 / API Keys app Home page "before all" hook for "Hides management link if user is not authorized"
[job] [logs] FTR Configs #59 / Canvas Canvas app smoke test "before all" hook for "loads workpad list"
[job] [logs] FTR Configs #87 / Cases - group 1 Create case "before each" hook for "creates a case from the stack management page"
[job] [logs] FTR Configs #64 / cloud_security_posture Cloud Posture Dashboard Page "after all" hook in "Cloud Posture Dashboard Page"
[job] [logs] FTR Configs #64 / cloud_security_posture Cloud Posture Dashboard Page "before all" hook in "Cloud Posture Dashboard Page"
[job] [logs] FTR Configs #101 / Controls "before all" hook: setup in "Controls"
[job] [logs] FTR Configs #44 / Cross Cluster Replication app feature controls security "before all" hook in "security"
[job] [logs] FTR Configs #83 / custom branding - functional tests custom branding "after all" hook for "should allow setting custom logo text through advanced settings"
[job] [logs] FTR Configs #83 / custom branding - functional tests custom branding "before all" hook for "should allow setting custom page title through advanced settings"
[job] [logs] FTR Configs #69 / Dashboard "before all" hook in "Dashboard"
[job] [logs] FTR Configs #85 / dashboard app - group 1 Changing field formatter to Url "before all" hook for "applied on dashboard"
[job] [logs] FTR Configs #13 / dashboard app - group 3 dashboard time picker "before all" hook for "Visualization updated when time picker changes"
[job] [logs] FTR Configs #16 / dashboard app - group 6 dashboard grid "before all" hook in "dashboard grid"
[job] [logs] FTR Configs #29 / dashboard sync colors should sync colors on dashboard by default
[job] [logs] FTR Configs #71 / Data Views feature controls security global data views all privileges "after all" hook for "doesn't show read-only badge"
[job] [logs] FTR Configs #71 / Data Views feature controls security global data views all privileges "before all" hook for "shows management navlink"
[job] [logs] FTR Configs #26 / disable Elastic Maps Service Fonts "before all" hook for "should load map with labels"
[job] [logs] FTR Configs #44 / discover feature controls discover feature controls security "after all" hook in "discover feature controls security"
[job] [logs] FTR Configs #44 / discover feature controls discover feature controls security "before all" hook in "discover feature controls security"
[job] [logs] FTR Configs #2 / discover/context_awareness root profile "before all" hook in "root profile"
[job] [logs] FTR Configs #81 / discover/context_awareness root profile "before all" hook in "root profile"
[job] [logs] FTR Configs #101 / discover/context_awareness root profile "before all" hook in "root profile"
[job] [logs] FTR Configs #8 / discover/context_awareness root profile ES|QL mode cell renderers should render custom @timestamp
[job] [logs] FTR Configs #63 / discover/embeddable discover saved search embeddable "before all" hook for "can save a search embeddable with a defined rows per page number"
[job] [logs] FTR Configs #86 / discover/embeddable discover saved search embeddable "before all" hook for "can save a search embeddable with a defined rows per page number"
[job] [logs] FTR Configs #98 / discover/embeddable discover saved search embeddable "before all" hook for "can save a search embeddable with a defined rows per page number"
[job] [logs] FTR Configs #86 / discover/embeddable discover saved search embeddable "before all" hook for "can save a search embeddable with a defined rows per page number"
[job] [logs] FTR Configs #98 / discover/embeddable discover saved search embeddable "before all" hook for "can save a search embeddable with a defined rows per page number"
[job] [logs] FTR Configs #63 / discover/embeddable discover saved search embeddable "before all" hook for "can save a search embeddable with a defined rows per page number"
[job] [logs] FTR Configs #43 / discover/group1 discover test "before all" hook in "discover test"
[job] [logs] FTR Configs #45 / discover/group1 discover test "before all" hook in "discover test"
[job] [logs] FTR Configs #48 / discover/group1 discover test "before all" hook in "discover test"
[job] [logs] FTR Configs #100 / discover/group1 discover test "before all" hook in "discover test"
[job] [logs] FTR Configs #48 / discover/group1 discover test "before all" hook in "discover test"
[job] [logs] FTR Configs #100 / discover/group1 discover test "before all" hook in "discover test"
[job] [logs] FTR Configs #95 / discover/group2/data_grid1 discover data grid tests "before all" hook for "can add fields to the table"
[job] [logs] FTR Configs #7 / discover/group2/data_grid2 discover data grid new line support "before each" hook for "should not show new lines for Document column"
[job] [logs] FTR Configs #74 / discover/group2/data_grid3 discover data grid row navigation "before all" hook for "should navigate through rows with the same id but different indices correctly"
[job] [logs] FTR Configs #71 / discover/group3 discover default columns "before each" hook for "should render default columns"
[job] [logs] FTR Configs #16 / discover/group4 discover uses fields API test "before all" hook for "should correctly display documents"
[job] [logs] FTR Configs #83 / discover/group6 discover sidebar "before each" hook for "should reveal and hide the filter form when the toggle is clicked"
[job] [logs] Threat Intelligence Cypress Tests / Empty Page "before each" hook for "should render the empty page with link to docs and integrations, and navigate to integrations page"
[job] [logs] FTR Configs #91 / GlobalSearch API GlobalSearch providers "before all" hook in "GlobalSearch providers"
[job] [logs] FTR Configs #10 / Hello world "before all" hook for "renders hello world text"
[job] [logs] FTR Configs #2 / home app Kibana takes you home clicking on kibana logo should take you to home page
[job] [logs] FTR Configs #100 / Interactive Setup Functional Tests (Enrollment token) should configure Kibana successfully
[job] [logs] FTR Configs #100 / Interactive Setup Functional Tests (Enrollment token) should configure Kibana successfully
[job] [logs] FTR Configs #81 / Journey[aiops_log_rate_analysis] Go to AIOps Log Rate Analysis
[job] [logs] FTR Configs #71 / Journey[apm_service_inventory] Navigate to Service Inventory Page
[job] [logs] FTR Configs #59 / Journey[dashboard_listing_page] Go to Dashboards Page
[job] [logs] FTR Configs #93 / Journey[data_stress_test_lens] Go to dashboard
[job] [logs] FTR Configs #93 / Journey[data_stress_test_lens] Go to dashboard
[job] [logs] FTR Configs #69 / Journey[ecommerce_dashboard_map_only] Go to Dashboards Page
[job] [logs] FTR Configs #83 / Journey[ecommerce_dashboard] Go to Dashboards Page
[job] [logs] FTR Configs #94 / Journey[flight_dashboard] Go to Dashboards Page
[job] [logs] FTR Configs #55 / Journey[infra_hosts_view] Navigate to Hosts view and load 500 hosts
[job] [logs] FTR Configs #87 / Journey[login] Login
[job] [logs] FTR Configs #28 / Journey[many_fields_lens_editor] Go to Visualize Library landing page
[job] [logs] FTR Configs #85 / Journey[promotion_tracking_dashboard] Go to Dashboards Page
[job] [logs] FTR Configs #7 / Journey[tags_listing_page] Go to Tags Page
[job] [logs] FTR Configs #68 / Journey[tsdb_logs_data_visualizer] Go to Data Visualizer
[job] [logs] Jest Tests #13 / Kubernetes security routes navigates to the kubernetes page
[job] [logs] FTR Configs #91 / lens app - group 3 lens add-to-dashboards tests should allow new lens to be added by value to a new dashboard
[job] [logs] FTR Configs #104 / lens app - group 4 lens color palette tests should allow to pick legacy color palette in xy chart
[job] [logs] FTR Configs #97 / lens app - TSVB Open in Lens Convert to Lens action on dashboard "before all" hook for "should show notification in context menu if visualization can be converted"
[job] [logs] FTR Configs #26 / lens app - TSVB Open in Lens Metric "before each" hook for "should show the "Edit Visualization in Lens" menu item"
[job] [logs] FTR Configs #67 / lens serverless - group 1 lens smokescreen tests "before all" hook for "should allow creation of lens xy chart"
[job] [logs] FTR Configs #92 / lens serverless - group 1 lens smokescreen tests "before all" hook for "should allow creation of lens xy chart"
[job] [logs] FTR Configs #93 / lens serverless - group 1 lens smokescreen tests "before all" hook for "should allow creation of lens xy chart"
[job] [logs] FTR Configs #67 / lens serverless - group 1 lens smokescreen tests "before all" hook for "should allow creation of lens xy chart"
[job] [logs] FTR Configs #93 / lens serverless - group 1 lens smokescreen tests "before all" hook for "should allow creation of lens xy chart"
[job] [logs] FTR Configs #92 / lens serverless - group 1 lens smokescreen tests "before all" hook for "should allow creation of lens xy chart"
[job] [logs] FTR Configs #82 / links panel "before all" hook: setup in "links panel"
[job] [logs] FTR Configs #55 / machine learning - anomaly detection "after all" hook in "machine learning - anomaly detection"
[job] [logs] FTR Configs #55 / machine learning - anomaly detection "before all" hook in "machine learning - anomaly detection"
[job] [logs] FTR Configs #79 / machine learning - data frame analytics "after all" hook in "machine learning - data frame analytics"
[job] [logs] FTR Configs #79 / machine learning - data frame analytics outlier detection creation "before all" hook in "outlier detection creation"
[job] [logs] FTR Configs #64 / machine learning - data visualizer "after all" hook in "machine learning - data visualizer"
[job] [logs] FTR Configs #64 / machine learning - data visualizer index based "before all" hook in "index based"
[job] [logs] FTR Configs #87 / machine learning - stack management jobs "after all" hook in "machine learning - stack management jobs"
[job] [logs] FTR Configs #87 / machine learning - stack management jobs synchronize "before all" hook for "should have nothing to sync initially"
[job] [logs] FTR Configs #26 / machine learning basic license - data visualizer - group 1 file based "before all" hook in "file based"
[job] [logs] FTR Configs #13 / machine learning basic license - data visualizer - group 2 index based "before all" hook in "index based"
[job] [logs] FTR Configs #104 / management "Create Index Pattern" wizard "after all" hook in ""Create Index Pattern" wizard"
[job] [logs] FTR Configs #32 / management "Create Index Pattern" wizard "before all" hook in ""Create Index Pattern" wizard"
[job] [logs] FTR Configs #104 / management "Create Index Pattern" wizard "before all" hook in ""Create Index Pattern" wizard"
[job] [logs] FTR Configs #32 / management "Create Index Pattern" wizard "before all" hook in ""Create Index Pattern" wizard"
[job] [logs] FTR Configs #94 / maps app dashboard reporting: creates a map report PNG file matches the baseline image, using sample geo data
[job] [logs] FTR Configs #8 / maps app esql "before all" hook for "should display ES|QL statement results on map"
[job] [logs] FTR Configs #7 / maps app geojson vector layer - es geo grid source geo_point "before all" hook for "should re-fetch geotile_grid aggregation with refresh timer"
[job] [logs] FTR Configs #96 / Newsfeed icon button handle errors "before all" hook for "clicking on newsfeed icon should open you empty newsfeed"
[job] [logs] FTR Configs #89 / ObservabilityApp Observability alerts > "before all" hook in "Observability alerts >"
[job] [logs] FTR Configs #29 / Remote Clusters app feature controls security "before all" hook in "security"
[job] [logs] Jest Tests #13 / renderApp Enterprise Search apps renders AppSearch
[job] [logs] Jest Tests #13 / renderApp Enterprise Search apps renders EnterpriseSearchOverview
[job] [logs] Jest Tests #13 / renderApp Enterprise Search apps renders WorkplaceSearch
[job] [logs] FTR Configs #43 / Reporting Functional Tests with Security disabled Polling for jobs Displays new jobs
[job] [logs] FTR Configs #80 / Reporting Functional Tests with Security enabled Security with reporting_user built-in role Dashboard: Generate CSV report does not allow user that does not have reporting privileges
[job] [logs] FTR Configs #89 / rollup app rollup job "after all" hook for "create new rollup job"
[job] [logs] FTR Configs #89 / rollup app rollup job "before all" hook for "shows deprecation prompt when there are no existing rollup jobs"
[job] [logs] FTR Configs #59 / Sanity checks Login Page "before all" hook for "login page meets i18n requirements"
[job] [logs] FTR Configs #85 / Saved Objects Management find saved objects with hidden type "before all" hook for "returns saved objects with importableAndExportable types"
[job] [logs] FTR Configs #80 / saved objects tagging - functional tests table listing "before all" hook in "table listing"
[job] [logs] FTR Configs #95 / Saved query management Feature controls Security: App vs Global privilege "after all" hook in "Security: App vs Global privilege"
[job] [logs] FTR Configs #95 / Saved query management Feature controls Security: App vs Global privilege "before all" hook in "Security: App vs Global privilege"
[job] [logs] FTR Configs #35 / security app - basic license Role Mappings "before all" hook for "does not render the Role Mappings UI under the basic license"
[job] [logs] FTR Configs #25 / Serverless Common UI - Examples data view field editor example "before all" hook in "data view field editor example"
[job] [logs] FTR Configs #10 / Serverless Common UI - Home Page home page "before all" hook for "has project header"
[job] [logs] FTR Configs #45 / Serverless Common UI - Home Page home page "before all" hook for "has project header"
[job] [logs] FTR Configs #28 / serverless observability UI navigation "before all" hook for "navigate observability sidenav & breadcrumbs"
[job] [logs] FTR Configs #35 / serverless security UI landing page "before all" hook for "has serverless side nav"
[job] [logs] FTR Configs #95 / Spaces app (with solution view) edit space solution view does show the solution view panel
[job] [logs] FTR Configs #16 / transform - edit & clone "after all" hook in "transform - edit & clone"
[job] [logs] FTR Configs #16 / transform - edit & clone cloning "before all" hook in "cloning"
[job] [logs] FTR Configs #25 / Uptime app with generated data uptime settings page "before each" hook: navigate to clean app root for "loads the default settings"
[job] [logs] FTR Configs #8 / User Profiles page User Profile Page Details "before all" hook for "should set the full name"
[job] [logs] FTR Configs #81 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie "before all" hook for "should hide the "Convert to Lens" menu item if no split slices were defined"
[job] [logs] FTR Configs #89 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie "before all" hook for "should hide the "Convert to Lens" menu item if no split slices were defined"
[job] [logs] FTR Configs #97 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens Pie "before all" hook for "should hide the "Convert to Lens" menu item if no split slices were defined"
[job] [logs] FTR Configs #75 / Visualizations - Group 3 "before all" hook in "Visualizations - Group 3"
[job] [logs] FTR Configs #82 / Visualizations - Group 3 "before all" hook in "Visualizations - Group 3"
[job] [logs] FTR Configs #96 / Visualizations - Group 3 "before all" hook in "Visualizations - Group 3"
[job] [logs] FTR Configs #68 / visualize app - new charts library visualize area charts "before all" hook for "should save and load with special characters"
[job] [logs] FTR Configs #94 / visualize app data-shared-item "before all" hook for "should have the correct data-shared-item title and description, and sharedItemContainer should exist"
[job] [logs] FTR Configs #91 / visualize app inspector "before all" hook in "inspector"
[job] [logs] FTR Configs #2 / visualize app tag cloud chart "before all" hook for "should have inspector enabled"
[job] [logs] FTR Configs #3 / visualize app visual builder "before each" hook for "should have inspector enabled"
[job] [logs] FTR Configs #90 / visualize app visual builder "before each" hook for "should render all necessary components"
[job] [logs] FTR Configs #94 / visualize app visual builder "before each" hook for "should render all necessary components"
[job] [logs] FTR Configs #89 / watcher app watcher_test "before all" hook: initialize tests for "create and save a new watch"
[job] [logs] FTR Configs #35 / X-Pack Accessibility Tests - Group 1 Security Accessibility Login Page "before all" hook for "login page meets a11y requirements"

History

💔 Build #224105 failed 6ffc6ad
💔 Build #223954 failed 7bddf5e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo @rshen91

maryam-saeidi · 2025-01-23T16:02:21Z

I think we can close this PR as we did the fix here: #204547

rshen91 added 2 commits June 20, 2024 08:00

initial commit refactor shared ux router

55d1de8

Merge remote-tracking branch 'upstream/main' into ctx-router

1c7cdc0

jasonrhodes mentioned this pull request Jun 20, 2024

chore(slo): integrate with stdperf #186477

Merged

rshen91 self-assigned this Jul 25, 2024

Merge remote-tracking branch 'upstream/main' into ctx-router

5bc0913

rshen91 added bug Fixes for quality problems that affect the customer experience Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Jul 25, 2024

rshen91 added 2 commits July 25, 2024 12:11

wip refactor context to have provider

0ca4f80

Merge remote-tracking branch 'upstream/main' into ctx-router

7bddf5e

rshen91 added the discuss label Jul 25, 2024

kibanamachine and others added 5 commits July 25, 2024 23:25

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

442caf3

…fix'

context is based off of application service

e7893f1

Merge remote-tracking branch 'origin/ctx-router' into ctx-router

f85eccc

Merge remote-tracking branch 'upstream/main' into ctx-router

211ecaa

fix

6ffc6ad

kibanamachine and others added 4 commits July 26, 2024 15:30

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

84a1a05

…fix'

update test

31fd4d2

Merge remote-tracking branch 'origin/ctx-router' into ctx-router

11d9632

Merge remote-tracking branch 'upstream/main' into ctx-router

9fd971b

rshen91 assigned eokoneyo Jul 26, 2024

rshen91 removed their assignment Jul 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Shared UX Router Component] Fix context implementation #186532

[Shared UX Router Component] Fix context implementation #186532
rshen91 wants to merge 14 commits intoelastic:mainfrom
rshen91:ctx-router

rshen91 commented Jun 20, 2024 •

edited

Loading

Uh oh!

rshen91 commented Jul 25, 2024

Uh oh!

rshen91 commented Jul 26, 2024

Uh oh!

rshen91 commented Jul 26, 2024

Uh oh!

kibana-ci commented Jul 26, 2024 •

edited

Loading

Uh oh!

maryam-saeidi commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rshen91 commented Jun 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

rshen91 commented Jul 25, 2024

Uh oh!

rshen91 commented Jul 26, 2024

Uh oh!

rshen91 commented Jul 26, 2024

Uh oh!

kibana-ci commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

Uh oh!

maryam-saeidi commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rshen91 commented Jun 20, 2024 •

edited

Loading

kibana-ci commented Jul 26, 2024 •

edited

Loading