Skip to content

[i18n][system upgrade] Upgrade i18n tooling#186519

Merged
Bamieh merged 25 commits intoelastic:mainfrom
Bamieh:i18n/tooling_update
Jul 16, 2024
Merged

[i18n][system upgrade] Upgrade i18n tooling#186519
Bamieh merged 25 commits intoelastic:mainfrom
Bamieh:i18n/tooling_update

Conversation

@Bamieh
Copy link
Contributor

@Bamieh Bamieh commented Jun 20, 2024

Update i18n tools after the main packages upgrade. This upgrade makes use of formatJS tooling instead of fully implementing the parsers ourselves. It also changes our custom AST parsing from babel to the typescript compiler.

  • i18n exrtract
  • i18n check
  • i18n integrate
  • add test cases for formatjs runner
  • Make sure all CLI flags are handled properly
  • Update tooling readme

Closes #180616
Closes #187703

Note to reviewers

Teams outside operations and core are probably requested to review because the i18n_check fixed malformed i18n messages in your plugins. Please check and approve :elasticheart:

@Bamieh Bamieh added backport:skip This PR does not require backporting 8.16 candidate labels Jun 20, 2024
@Bamieh Bamieh marked this pull request as ready for review July 4, 2024 15:38
@Bamieh Bamieh requested review from a team as code owners July 4, 2024 15:38
@Bamieh Bamieh requested review from a team and nikitaindik July 4, 2024 15:39
@Bamieh Bamieh added the release_note:skip Skip the PR/issue when compiling release notes label Jul 4, 2024
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 4, 2024
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM change LGTM

@Bamieh Bamieh requested review from Ikuni17 and criamico July 15, 2024 12:56
@Bamieh
Copy link
Contributor Author

Bamieh commented Jul 15, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet LGTM

@Bamieh Bamieh enabled auto-merge (squash) July 16, 2024 18:12
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 16, 2024

⏳ Build in-progress

Failed CI Steps

History

@Bamieh Bamieh merged commit 7c6aa3f into elastic:main Jul 16, 2024
@Bamieh Bamieh deleted the i18n/tooling_update branch July 17, 2024 10:03
@dokmic dokmic mentioned this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.16 candidate apm:review backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ES|QL] i18n error in console when adding an ES|QL chart to dashboard [i18n][system upgrade] Upgrade i18n tooling