Failing test: Jest Tests.x-pack/plugins/security_solution/public/detection_engine/rule_gaps/components/manual_rule_run - ManualRuleRunModal should render confirmation button disabled if selected end date is in future (#186189)#186296
Conversation
…ction_engine/rule_gaps/components/manual_rule_run - ManualRuleRunModal should render confirmation button disabled if selected end date is in future (elastic#186189)
e40pud
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
|
@elasticmachine merge upstream |
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
@e40pud these changes look reasonable, but I'm not seeing any explanation as to what the problem was (that caused the NoMethodError for scrollIntoView), or how these changes address that problem.
If you could provide some of that context, that would help both review and posterity. Thanks!
...ecurity_solution/public/detection_engine/rule_gaps/components/manual_rule_run/index.test.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
@rylnd I was never able to reproduce the issue locally and thus decided to restructure tests and used methods. My initial thoughts were that the cause is the Now, I found this discussion https://stackoverflow.com/a/53294906 and the link to the issue jsdom/jsdom#1695. Updated tests and added proposed solution. I still would like to keep my changes in this PR besides the actual fix - I feel that it looks more clear and easier to grasp. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @e40pud |
|
That's great info, thanks @e40pud! |
…ction_engine/rule_gaps/components/manual_rule_run - ManualRuleRunModal should render confirmation button disabled if selected end date is in future (elastic#186189) (elastic#186296) ## Summary Related tickets elastic#186189 and elastic#186187, and elastic#186188 Attempt to fix failing manual rule run tests added in this PR elastic#184500 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
5 participants
Summary
Related tickets #186189 and #186187, and #186188
Attempt to fix failing manual rule run tests added in this PR #184500