Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] DetectionRulesClient: return RuleResponse from all methods #186179

Merged
merged 8 commits into from
Jun 21, 2024
Merged

[Security Solution] DetectionRulesClient: return RuleResponse from all methods #186179

merged 8 commits into from
Jun 21, 2024

Commits on Jun 18, 2024

  1. Make updateRule method return RuleResponse

    @nikitaindik
    nikitaindik committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    713512d View commit details
    Browse the repository at this point in the history

  2. Make patchRule method return RuleResponse

    @nikitaindik
    nikitaindik committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c53db9c View commit details
    Browse the repository at this point in the history

  3. Make upgradePrebuiltRule method return RuleResponse

    @nikitaindik
    nikitaindik committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b6293f6 View commit details
    Browse the repository at this point in the history

  4. Make importRule method return RuleResponse

    @nikitaindik
    nikitaindik committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c8f9519 View commit details
    Browse the repository at this point in the history

  5. Fix failing tests

    @nikitaindik
    nikitaindik committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    bfcac78 View commit details
    Browse the repository at this point in the history

  6. Do not call toggleRuleEnabledOnUpdate in upgradePrebuiltRule, sin… 

    …ce it won't do anything
    @nikitaindik
    nikitaindik committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8d3fe01 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Address code review feedback

    @nikitaindik
    nikitaindik committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    463cb0e View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'main' into detection-rules-client-pr-5

    @nikitaindik
    nikitaindik authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    39dd3e9 View commit details
    Browse the repository at this point in the history