[ResponseOps][Cases] Allow users to edit or delete template by js-jankisalvi · Pull Request #185877 · elastic/kibana

js-jankisalvi · 2024-06-10T14:01:03Z

Summary

Merging into feature branch.

Implements edit and delete functionality #181864

Edit or delete template from case settings page.

Screen.Recording.2024-06-17.at.14.21.44.mov

How to test

Go to Cases > Settings
Add a template
Click on edit template icon
Update the fields
Click save
Click on delete template icon
Click on confirm modal
Click save

Scenarios:

Edit template with different custom fields
Edit template with connector
Delete template

Flaky Test here

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)

js-jankisalvi · 2024-06-13T14:03:03Z

/ci

js-jankisalvi · 2024-06-13T16:16:03Z

/ci

elasticmachine · 2024-06-17T13:32:19Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2024-06-17T13:32:20Z

Pinging @elastic/response-ops-cases (Feature:Cases)

js-jankisalvi · 2024-06-17T14:27:58Z

x-pack/plugins/cases/public/components/connectors/resilient/case_fields.tsx

-              (allIncidentTypes ?? []).find((type) => incidentType === type.id.toString())?.name ??
-              '',
-          }));
+          const selectedOptions =


Made this change to fix this weird behaviour in UI

kibanamachine · 2024-06-17T15:18:41Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6331

[✅] x-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts: 25/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/observability/config.ts: 0/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/security/config.ts: 24/25 tests passed.

see run history

doakalexi

I tested locally and works expected. I was able to edit and delete templates. LGTM!

cnasikas

LGTM! I tested and I found the following bugs

I cannot remove the parent from Jira

Screen.Recording.2024-06-18.at.3.21.42.PM.mov

The first category on SecOps is selected but the subcategories are not shown

Screen.Recording.2024-06-18.at.3.46.59.PM.mov

When changing connectors the fields are not resetted

Screen.Recording.2024-06-18.at.3.23.10.PM.mov

Also, the size of the component in x-pack/plugins/cases/public/components/configure_cases/index.tsx it grows a lot and I get the following warning. Maybe we can fix it on another PR.

In my PR I change the way the connectors are being handled. Bugs 2 and 3 will be fixed there.

x-pack/plugins/cases/public/components/connectors/jira/use_get_issue.test.tsx

x-pack/plugins/cases/public/components/templates/translations.ts

x-pack/plugins/cases/public/components/templates/utils.ts

cnasikas · 2024-06-19T07:52:06Z

x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts

+          return await testSubjects.exists('templates-list');
+        });
+
+        expect(await testSubjects.getVisibleText('templates-list')).to.be(


nit: Should we verify the rest of the updated fields?

I will create a separate PR to create connector and custom field utils for e2e tests.

x-pack/plugins/cases/public/components/templates/templates_list.tsx

js-jankisalvi · 2024-06-19T17:55:59Z

I cannot remove the parent from Jira

Fixed here

js-jankisalvi · 2024-06-19T22:06:36Z

@elasticmachine merge upstream

kibana-ci · 2024-06-19T23:34:45Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #62 / ML app anomaly detection alert overview page alert flyout controls can create an anomaly detection alert
[job] [logs] FTR Configs #62 / ML app anomaly detection alert overview page alert flyout controls can create an anomaly detection alert
[job] [logs] Jest Tests #13 / UserCommentPropertyActions renders the correct number of actions

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [f975c33]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

kibanamachine · 2024-06-20T00:04:31Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6360

[❌] x-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts: 11/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/observability/config.ts: 14/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/security/config.ts: 25/25 tests passed.

see run history

## Summary This PR adds the ability for users to select a template when creating a case. When a user selects a template the cases form fields are populated with the values from the template. The solution picker in the flyout changed as: <img width="1281" alt="Screenshot 2024-06-20 at 1 26 14 PM" src="https://github.com/elastic/kibana/assets/7871006/30859c61-94e7-4f0a-97d1-cb081bd72c36"> ## Bug fixes 1. Changing the solution through the solution picket in the flyout would not respect the connector's configuration. 2. Bug where the lazy loading of connectors' icons was causing the flyout to open and close when you selected a solution picket. This bug appeared when the first bug was fixed. ## Testing 1. Go to all solutions and create cases setting all fields (including all fields of all supported connectors) without using templates. Verify that everything is working as expected. 2. Go to all solutions, create different templates on each solution, and verify that when creating a case you can use templates and everything is working as expected. 3. Go to the alerts table of o11y and security and attach alerts to a new case. Verify that in the flyout the templates are working as expected. 4. Go to ML and try to attach an ML visualization to a new case. Verify that the solution picker is working as expected and it resets the form when changing solutions. Fixes: #181871 Depends on: #185877 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Janki Salvi <117571355+js-jankisalvi@users.noreply.github.com> Co-authored-by: adcoelho <antonio.coelho@elastic.co>

initial commit

d6e897b

js-jankisalvi added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Cases Cases feature v8.15.0 labels Jun 10, 2024

js-jankisalvi self-assigned this Jun 10, 2024

js-jankisalvi added 5 commits June 10, 2024 18:14

edit connector data

4092529

add unit tests

eaf57b7

add more unit tests

fe52101

add e2e test

94e3a47

remove watch for tags and assignees

8ebab81

js-jankisalvi added 2 commits June 13, 2024 16:02

fix tags tests changes, add defaultValue tests for custom fields

8688582

fix incident types issue

71831ef

cleanup

744262e

js-jankisalvi marked this pull request as ready for review June 17, 2024 13:32

js-jankisalvi requested a review from a team as a code owner June 17, 2024 13:32

js-jankisalvi requested review from cnasikas and doakalexi June 17, 2024 13:32

Merge branch 'feat/case_templates' into edit-delete-template

abbc024

js-jankisalvi commented Jun 17, 2024

View reviewed changes

doakalexi approved these changes Jun 18, 2024

View reviewed changes

cnasikas mentioned this pull request Jun 19, 2024

[Cases] Use templates when creating a case #185880

Merged

3 tasks

cnasikas approved these changes Jun 19, 2024

View reviewed changes

cnasikas added Feature:Cases Cases feature and removed Feature:Cases Cases feature labels Jun 19, 2024

js-jankisalvi added 2 commits June 19, 2024 18:32

PR feedback

64e165f

lint fix

fc0db28

Merge branch 'feat/case_templates' into edit-delete-template

f011255

js-jankisalvi merged commit c3b0759 into elastic:feat/case_templates Jun 19, 2024

js-jankisalvi deleted the edit-delete-template branch June 19, 2024 23:58

Conversation

js-jankisalvi commented Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

js-jankisalvi commented Jun 13, 2024

Uh oh!

js-jankisalvi commented Jun 13, 2024

Uh oh!

elasticmachine commented Jun 17, 2024

Uh oh!

elasticmachine commented Jun 17, 2024

Uh oh!

js-jankisalvi Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 17, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6331

Uh oh!

doakalexi left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cnasikas Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

js-jankisalvi Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

js-jankisalvi commented Jun 19, 2024

Uh oh!

js-jankisalvi commented Jun 19, 2024

Uh oh!

kibana-ci commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

History

Uh oh!

kibanamachine commented Jun 20, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6360

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

js-jankisalvi commented Jun 10, 2024 •

edited

Loading

js-jankisalvi Jun 17, 2024 •

edited

Loading

kibana-ci commented Jun 19, 2024 •

edited

Loading