[Security Solution] DetectionRulesClient: return RuleResponse from createCustomRule and createPrebuiltRule
#185748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaindik
added
refactoring
backport:skip
nikitaindik
changed the title
DetectionRulesClient: return RuleResponse from public methodsDetectionRulesClient: return RuleResponse from createCustomRule and createPrebuiltRule
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
nikitaindik
added
the
release_note:skip
|
/ci |
17 tasks
banderror
reviewed
Jun 10, 2024
...ity_solution/server/lib/detection_engine/rule_management/api/rules/create_rule/route.test.ts
Show resolved
Hide resolved
...tion_engine/rule_management/logic/detection_rules_client/detection_rules_client_interface.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/detection_engine/routes/utils.ts
Outdated
Show resolved
Hide resolved
.../detection_engine/rule_management/logic/detection_rules_client/methods/create_custom_rule.ts
Outdated
Show resolved
Hide resolved
...etection_engine/rule_management/logic/detection_rules_client/methods/create_prebuilt_rule.ts
Outdated
Show resolved
Hide resolved
dplumlee
reviewed
Jun 10, 2024
...y_solution/server/lib/detection_engine/rule_management/logic/detection_rules_client/utils.ts
Outdated
Show resolved
Hide resolved
|
Thanks for the review folks! Moving it to Draft now while I do the changes. Will notify you guys once it's ready for another look. |
|
Addressed the feedback. Reopening the PR for review. |
|
/ci |
|
/ci |
nikitaindik
force-pushed
the
detection-rules-client-rule-response
branch
from
cc2382c
to
74ff7a0
Compare
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nikitaindik |
bhapas
pushed a commit
to bhapas/kibana
that referenced
this pull request
Jun 18, 2024
…m `createCustomRule` and `createPrebuiltRule` (elastic#185748) **Partially addresses: elastic#184364 ## Summary This PR changes `createCustomRule` and `createPrebuiltRule` methods to return `RuleResponse` instead of `RuleAlertType`. This is a continuation of the effort to improve `DetectionRulesClient`. As a part of it we want to make the client return `RuleResponse` from all its public methods. This is good because it lets us hide rule's internal structure and centralise conversions in one place – in the client. So in this and upcoming PRs we are going to convert `RuleAlertType` to `RuleResponse` within the client's methods and return the `RuleResponse` object.
nikitaindik
added a commit
that referenced
this pull request
Jun 21, 2024
…m all methods (#186179) **Partially addresses: #184364 ## Summary This PR is a follow-up to [PR #185748](#185748) and it converts the remaining `DetectionRulesClient` methods to return `RuleResponse`. Changes in this PR: - These methods now return `RuleResponse` instead of internal `RuleAlertType` type: - `updateRule` - `patchRule` - `upgradePrebuiltRule` - `importRule`
bhapas
pushed a commit
to bhapas/kibana
that referenced
this pull request
Jun 24, 2024
…m all methods (elastic#186179) **Partially addresses: elastic#184364 ## Summary This PR is a follow-up to [PR elastic#185748](elastic#185748) and it converts the remaining `DetectionRulesClient` methods to return `RuleResponse`. Changes in this PR: - These methods now return `RuleResponse` instead of internal `RuleAlertType` type: - `updateRule` - `patchRule` - `upgradePrebuiltRule` - `importRule`
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #184364
Summary
This PR changes
createCustomRuleandcreatePrebuiltRulemethods to returnRuleResponseinstead ofRuleAlertType.This is a continuation of the effort to improve
DetectionRulesClient. As a part of it we want to make the client returnRuleResponsefrom all its public methods. This is good because it lets us hide rule's internal structure and centralise conversions in one place – in the client. So in this and upcoming PRs we are going to convertRuleAlertTypetoRuleResponsewithin the client's methods and return theRuleResponseobject.