Skip to content

[UII] Update package spec min version to 3.0 for serverless projects#184792

Merged
jen-huang merged 8 commits intoelastic:mainfrom
jen-huang:feat/serverless-pkg-spec
Sep 11, 2024
Merged

[UII] Update package spec min version to 3.0 for serverless projects#184792
jen-huang merged 8 commits intoelastic:mainfrom
jen-huang:feat/serverless-pkg-spec

Conversation

@jen-huang
Copy link
Copy Markdown
Contributor

@jen-huang jen-huang commented Jun 5, 2024

Summary

Resolves #182827

As the title says :)

This also corrects spec.max to 3.1, which it should have been all along.

Integrations available for Observability projects after change:
Click here

Integrations available for Security projects after change:
Click here

@jen-huang jen-huang self-assigned this Jun 5, 2024
@ghost
Copy link
Copy Markdown

ghost commented Jun 5, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jen-huang jen-huang added ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project labels Jun 5, 2024
@jen-huang
Copy link
Copy Markdown
Contributor Author

/ci

@jen-huang jen-huang added the release_note:skip Skip the PR/issue when compiling release notes label Jun 5, 2024
@jen-huang
Copy link
Copy Markdown
Contributor Author

The Observability serverless tests are failing because it is expecting apache package to be available & installable. However, apache does not appear because spec.max and spec.min are both set to 3.0, so only packages that are exactly on that format_version are shown on Serverless. There is no version of apache that is exactly on 3.0, it was migrated to 3.1.4 right away: https://github.com/elastic/integrations/pull/9818/files#diff-c1bfeefb3a7a71c324e3d6ee4ea6ed2b3cb6fd640e040b146c03582c3216cf37

It seems that there are four packages which are now on package spec > 3.0:
https://epr.elastic.co/search?spec.min=3.1
(apache, azure_metrics, kubernetes, lumos)

For serverless, I propose to either:

  • Remove xpack.fleet.internal.registry.spec.max restriction
  • Bump xpack.fleet.internal.registry.spec.max to 3.99 (probably safer)

@jsoriano @kpollich WDYT?

@kpollich
Copy link
Copy Markdown
Member

kpollich commented Jun 5, 2024

Remove xpack.fleet.internal.registry.spec.max restriction

I'm sure we have a good reason for keeping this around, but I am a little surprised that we don't just have a min in place. My immediate instinct is to remove the max constraint, but I might be missing some important context.

Bump xpack.fleet.internal.registry.spec.max to 3.99 (probably safer)

I agree that this is safer, and we aren't likely to reach such a high minor format_version value for the package spec before introducing a 4.0 version. This seems like the best short-term path forward to me.

@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Jun 5, 2024

spec.max should be set to 3.1 at this point. We use this versioning to ensure that a given deployment of kibana only uses versions of the spec it implements.

@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Jun 5, 2024

I am a little surprised that we don't just have a min in place.

Regarding this, we could not set a min version because there were many packages using old versions of the spec.

@jen-huang
Copy link
Copy Markdown
Contributor Author

I am a little surprised that we don't just have a min in place.

Regarding this, we could not set a min version because there were many packages using old versions of the spec.

I think Kyle mean just having the min and no max. Regardless, I pushed up the change to set spec.max to 3.1. Thanks for the clarifications!

@jen-huang
Copy link
Copy Markdown
Contributor Author

/ci

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 6, 2024
@jen-huang jen-huang marked this pull request as ready for review June 6, 2024 19:29
@jen-huang jen-huang requested review from a team as code owners June 6, 2024 19:29
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link
Copy Markdown
Contributor Author

I would like some folks from Observability and Security to approve this change before merging. For the folks below, you can see the Elastic Agent integrations available (including beta ones) after this change in the screenshots in this PR description, or you can view them in the serverless deployments for this PR that was created by CI (grab the URLs and creds from Buildkite or DM me).

@vinaychandrasekhar Can you review the Observability integrations?

@jamiehynds @cpascale43 Can you review the Security integrations?

@jen-huang
Copy link
Copy Markdown
Contributor Author

After review with @cpascale43, we found that these integrations are missing after this change because they are not updated to v3:

@jsoriano
Copy link
Copy Markdown
Member

I think we should update the max version, independently with what we do with the min version by now. I have opened a separate PR for this #192493.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 11, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang removed ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project labels Sep 11, 2024
@jen-huang jen-huang merged commit c4b7a82 into elastic:main Sep 11, 2024
@jen-huang jen-huang deleted the feat/serverless-pkg-spec branch September 11, 2024 20:04
@kibanamachine kibanamachine added v8.16.0 backport:skip This PR does not require backporting labels Sep 11, 2024
jlind23 pushed a commit that referenced this pull request Sep 12, 2024
Kibana should already support packages with spec version 3.2, update the
max version in serverless.

Supersedes part of #184792.

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] Reenable package spec version filtering for serverless

8 participants