[ResponseOps][Cases] Add tags to template in configure api#183743
[ResponseOps][Cases] Add tags to template in configure api#183743js-jankisalvi merged 5 commits intoelastic:feat/case_templatesfrom
Conversation
js-jankisalvi
added
release_note:skip
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
| caseFields: rt.union([rt.null, CaseBaseOptionalFieldsRequestRt]), | ||
| }); | ||
| rt.exact( | ||
| rt.partial({ |
There was a problem hiding this comment.
super nit: Do the tags need to be partial? I feel like saying they're an array with minlength 0 achieves the same and is way less verbose.
There was a problem hiding this comment.
Without partial and with minLength: 0 , it will still force user to add tags:[] param in each request. Where as partial makes it optional to add
There was a problem hiding this comment.
yy I know, but I thought why not have tags: [] anyway if they are the same 🤷 Anyway, not a big deal. Feel free to leave as is 👍
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
6 participants
Summary
Parent issue: #181309
This PR adds optional tags field in template.
Checklist