Merged
Conversation
`docker login` was localized to a single step and was managed only in that step. Over time, this has expanded most pipelines and steps. This changes the pattern to authenticate once during pre command.
jbudz
added
Team:Operations
Contributor
Author
|
buildkite test this |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
Ikuni17
approved these changes
May 13, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 13, 2024
Originally `docker login` was localized to a single step and was managed only in that step. Over time, this has expanded most pipelines and steps. This changes the pattern to authenticate once during pre command. (cherry picked from commit 306e5ec)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 13, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [[ci] Refactor docker login (#183278)](#183278) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-05-13T15:15:02Z","message":"[ci] Refactor docker login (#183278)\n\nOriginally `docker login` was localized to a single step and was managed\r\nonly in that step. Over time, this has expanded most pipelines and\r\nsteps. This changes the pattern to authenticate once during pre command.","sha":"306e5ec8643eb03ff2b8769959bff5785306648b","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.15.0"],"title":"[ci] Refactor docker login","number":183278,"url":"https://github.com/elastic/kibana/pull/183278","mergeCommit":{"message":"[ci] Refactor docker login (#183278)\n\nOriginally `docker login` was localized to a single step and was managed\r\nonly in that step. Over time, this has expanded most pipelines and\r\nsteps. This changes the pattern to authenticate once during pre command.","sha":"306e5ec8643eb03ff2b8769959bff5785306648b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183278","number":183278,"mergeCommit":{"message":"[ci] Refactor docker login (#183278)\n\nOriginally `docker login` was localized to a single step and was managed\r\nonly in that step. Over time, this has expanded most pipelines and\r\nsteps. This changes the pattern to authenticate once during pre command.","sha":"306e5ec8643eb03ff2b8769959bff5785306648b"}}]}] BACKPORT--> Co-authored-by: Jon <jon@elastic.co>
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
May 14, 2024
jbudz
added a commit
that referenced
this pull request
May 14, 2024
adelisle
pushed a commit
to Makila-AI/kibana
that referenced
this pull request
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally
docker loginwas localized to a single step and was managed only in that step. Over time, this has expanded most pipelines and steps. This changes the pattern to authenticate once during pre command.