[Cases] Case templates configure api#183231
Merged
js-jankisalvi merged 11 commits intoelastic:feat/case_templatesfrom May 14, 2024
Merged
[Cases] Case templates configure api#183231js-jankisalvi merged 11 commits intoelastic:feat/case_templatesfrom
js-jankisalvi merged 11 commits intoelastic:feat/case_templatesfrom
Conversation
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
Contributor
Author
|
@elasticmachine merge upstream |
7c18ad1 to
e3775af
Compare
cnasikas
approved these changes
May 14, 2024
Member
cnasikas
left a comment
There was a problem hiding this comment.
Great PR! Great code coverage!!
| ); | ||
| } | ||
|
|
||
| licensingService.notifyUsage(LICENSING_CASE_ASSIGNMENT_FEATURE); |
Member
There was a problem hiding this comment.
Do we need to first check if there are assignees before notifying? Also, should we notify once outside the loop? Example:
const hasAssigneesInTemplate = templates.some((template) => Boolean(template.caseFields?.assignees && template.caseFields?.assignees.length > 0))
if (hasAssigneesInTemplate && !hasPlatinumLicenseOrGreater) {
throw Boom.forbidden(
'In order to assign users to cases, you must be subscribed to an Elastic Platinum license'
);
}
if (hasAssigneesInTemplate) {
licensingService.notifyUsage(LICENSING_CASE_ASSIGNMENT_FEATURE);
}
templates.forEach((template, index) => { /// the validation }
Contributor
Author
There was a problem hiding this comment.
Updated in d9bcdbc
No need of forEach loop anymore
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #181573
This PR allows users to create, update and delete templates using existing configure API
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5846
Test via Postman:
Checklist