Upgrade EUI to v94.3.0 by tkajtoch · Pull Request #182822 · elastic/kibana

tkajtoch · 2024-05-07T12:21:24Z

v94.2.1-backport.0 ⏩ v94.3.0

Questions? Please see our Kibana upgrade FAQ.

`v94.3.0`

Updated launch glyph for EuiIcon (#7670)
Updated EuiComboBox's options to support including tooltip details for selectable options. Use toolTipContent to render tooltip information, and toolTipProps to optionally customize the tooltip rendering behavior (#7700)
Updated the following existing glyphs in EuiIcon: (#7727)
- error (now an outlined version instead of filled)
- tokenMetricCounter
- tokenMetricGauge
Added the following new glyphs to EuiIcon: (#7727)
- tokenDimension
- clickLeft
- clickRight
- clockCounter
- errorFilled (the previous error glyph design)
- warningFilled

Bug fixes

Fixed a visual layout bug for EuiComboBox with isLoading in mobile views (#7700)
Fixed missing styles on header cells of EuiDataGrid that prevented content text alignment styles to apply (#7720)
Fixed EuiFlexGroup and EuiFlexItem ref prop typing to support refs of the same type as the passed component type and allow displayName to be defined for easy component naming when using component wrappers like styled() (#7724)

Most of the code changes you'll see in this PR are caused by the recent EuiFlex* changes making it generic. This, unfortunately, is something that styled() doesn't always like. I replaced the failing usages of styled(EuiFlexGroup) and styled(EuiFlexItem) to use component and other native EuiFlex* props, resulting in the same output but being better typed.

We plan to add more props to EuiFlex* components giving developers control over properties like flex-grow and flex-shring, and reducing the need for writing any custom CSS when using these components. This should reduce the number of styled() wrappers needed even further

…` usages

…exGroup` and `EuiFlexItem`

…-fix'

…stamp` field

tkajtoch · 2024-05-09T11:44:40Z

Synthetics tests were also failing on main when tested locally and I can't see a correlation between the update and that test suite failing

elasticmachine · 2024-05-09T13:22:35Z

Pinging @elastic/eui-team (EUI)

elasticmachine · 2024-05-09T14:04:26Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine · 2024-05-09T14:04:26Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Heenawter

Canvas snapshot changes LGTM

kdelemme

ux management code change LGTM!

tonyghiani

logs_explorer changes LGTM

ElenaStoeva

ILM test snapshot changes LGTM

tomsonpl · 2024-05-09T17:18:40Z

x-pack/plugins/security_solution/public/management/cypress/fixtures/artifacts_page.ts

        {
-          type: 'click',
-          customSelector: 'button[title="@timestamp"]',
+          type: 'input',


Was this change intentional? How comes click on a button changes into input? 🤔

It was intentional. I'm not entirely sure why it was needed only here, but generally speaking, we prefer using keyboard navigation when selecting combobox items.

Previously, it was a click on an option with a specified name; now, it's typing the option name into the search field and selecting the first option, which is the exact match. This way should be more reliable no matter what order the items are displayed in, too.

tomsonpl

Defend Workflows LGTM 👍

cauemarcondes

LGTM

jughosta

Data Discovery changes LGTM 👍

tkajtoch · 2024-05-10T12:31:34Z

The failing synthetics tests are also failing on main and have been failing since (at least) the synthetics move introduced in #177464 (failing buildkite job).

PhilippeOberti

desk tested, thanks for the cleanup! LGTM for the Threat Hunting Investigations team!

tkajtoch · 2024-05-10T16:14:17Z

@elasticmachine merge upstream

kibana-ci · 2024-05-10T17:07:53Z

💔 Build Failed

Buildkite Build
Commit: fe9d60c
Interpreting CI Failures
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-182822-fe9d60cf16ca
Observability Deployment

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.5MB	1.5MB	+139.0B
`observability`	286.2KB	286.0KB	-164.0B
`securitySolution`	15.1MB	15.1MB	-909.0B
`synthetics`	1.0MB	1.0MB	-5.0B
total			-939.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5407	+5407
`total size`	-	8.8MB	+8.8MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	253.9KB	254.0KB	+71.0B
`kbnUiSharedDeps-npmDll`	6.3MB	6.3MB	+1.8KB
`kbnUiSharedDeps-srcJs`	3.1MB	3.1MB	-1.0B
total			+1.9KB

History

💔 Build #209150 failed 277e1fa
💔 Build #208924 failed 9c48c2b
💔 Build #208896 failed 3ad952a9a5d5381ca5014c6422e330c0e2d266d3
💔 Build #208870 failed 7548f5d21364834f25eca0d3a623d14693f53dfc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

This reverts commit e714cfa.

This reverts commit afbb257.

tkajtoch added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting v8.15.0 labels May 7, 2024

tkajtoch self-assigned this May 7, 2024

tkajtoch force-pushed the feat/eui-94.3.0 branch 2 times, most recently from 7548f5d to 3ad952a Compare May 9, 2024 07:12

tkajtoch and others added 5 commits May 9, 2024 12:48

chore: update @elastic/eui to v94.3.0

d056263

feat: cleanup failing styled(EuiFlexGroup) and `styled(EuiFlexItem)…

eda8789

…` usages

test: update snapshots to adjust for the changes introduced in `EuiFl…

5c7668c

…exGroup` and `EuiFlexItem`

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

a6b1b32

…-fix'

test: fix Event Filters form actions to use keyboard to select `@time…

9c48c2b

…stamp` field

tkajtoch force-pushed the feat/eui-94.3.0 branch from 3ad952a to 9c48c2b Compare May 9, 2024 10:48

tkajtoch marked this pull request as ready for review May 9, 2024 13:22

tkajtoch requested review from a team as code owners May 9, 2024 13:22

tkajtoch requested a review from a team May 9, 2024 13:22

tkajtoch requested review from a team as code owners May 9, 2024 13:22

tkajtoch requested review from pzl and tomsonpl May 9, 2024 13:22

pzl requested review from parkiino and removed request for pzl May 9, 2024 13:23

Ikuni17 approved these changes May 9, 2024

View reviewed changes

Heenawter approved these changes May 9, 2024

View reviewed changes

kdelemme approved these changes May 9, 2024

View reviewed changes

tonyghiani approved these changes May 9, 2024

View reviewed changes

dhurley14 approved these changes May 9, 2024

View reviewed changes

smith added the apm:review label May 9, 2024

ElenaStoeva approved these changes May 9, 2024

View reviewed changes

tomsonpl reviewed May 9, 2024

View reviewed changes

seanrathier approved these changes May 9, 2024

View reviewed changes

tomsonpl approved these changes May 9, 2024

View reviewed changes

Merge branch 'main' into feat/eui-94.3.0

277e1fa

cauemarcondes approved these changes May 10, 2024

View reviewed changes

jughosta approved these changes May 10, 2024

View reviewed changes

PhilippeOberti approved these changes May 10, 2024

View reviewed changes

angorayc approved these changes May 10, 2024

View reviewed changes

Merge branch 'main' into feat/eui-94.3.0

fe9d60c

jbudz merged commit e714cfa into elastic:main May 10, 2024

jbudz added a commit to jbudz/kibana that referenced this pull request May 13, 2024

Revert "Upgrade EUI to v94.3.0 (elastic#182822)"

afbb257

This reverts commit e714cfa.

jbudz added a commit to jbudz/kibana that referenced this pull request May 13, 2024

Reapply "Upgrade EUI to v94.3.0 (elastic#182822)"

e10c0a8

This reverts commit afbb257.

Conversation

tkajtoch commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v94.3.0

Uh oh!

tkajtoch commented May 9, 2024

Uh oh!

elasticmachine commented May 9, 2024

Uh oh!

elasticmachine commented May 9, 2024

Uh oh!

elasticmachine commented May 9, 2024

Uh oh!

Heenawter left a comment

Choose a reason for hiding this comment

Uh oh!

kdelemme left a comment

Choose a reason for hiding this comment

Uh oh!

tonyghiani left a comment

Choose a reason for hiding this comment

Uh oh!

ElenaStoeva left a comment

Choose a reason for hiding this comment

Uh oh!

tomsonpl May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tkajtoch May 9, 2024

Choose a reason for hiding this comment

Uh oh!

tomsonpl left a comment

Choose a reason for hiding this comment

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

tkajtoch commented May 10, 2024

Uh oh!

PhilippeOberti left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tkajtoch commented May 10, 2024

Uh oh!

kibana-ci commented May 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Canvas Sharable Runtime

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

tkajtoch commented May 7, 2024 •

edited

Loading

`v94.3.0`

tomsonpl May 9, 2024 •

edited

Loading

PhilippeOberti left a comment •

edited

Loading

kibana-ci commented May 10, 2024 •

edited

Loading