[Enterprise Search] Fix EuiPageTemplate child usages#182711
Merged
cee-chen merged 2 commits intoelastic:mainfrom May 9, 2024
Merged
[Enterprise Search] Fix EuiPageTemplate child usages#182711cee-chen merged 2 commits intoelastic:mainfrom
EuiPageTemplate child usages#182711cee-chen merged 2 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Member
|
Thank you @cee-chen for taking care of this. Screen.Recording.2024-05-08.at.10.23.19.PM.movafter Screen.Recording.2024-05-08.at.10.22.46.PM.movOverall, I think now layout looks much better 🎉 |
saarikabhasi
approved these changes
May 9, 2024
Contributor
Author
|
Whew! Thanks for checking that and apologies for mildly breaking your layouts in the first place! 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


👋 Hey y'all ent search folks! I missed this fix/update update in our latest EUI upgrade (#182023). It's directly related to this change in EUI v94.2.0:
In general, it's also a best practice to use EuiPageTemplate's namespaced children instead of the direct
EuiPage*components (which are meant for direct usage within aEuiPagecomponent instead), so I've made similar changes to your code as well. I would suggest pulling down this PR to QA that your page still looks as expected/as before.