Skip to content

[Security] Ftr API Integration tests#182626

Merged
MadameSheema merged 2 commits intomainfrom
security-ftr-fix
May 6, 2024
Merged

[Security] Ftr API Integration tests#182626
MadameSheema merged 2 commits intomainfrom
security-ftr-fix

Conversation

@dkirchan
Copy link
Contributor

@dkirchan dkirchan commented May 4, 2024

Summary

Try catch statement in the PR for the API Ftr Integration tests, introduced a cover above the target fix of the specific PR.

The tests were failing however the exit code was still 0 so the failures are hidden. This PR addresses the specific issue.

@dkirchan dkirchan added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0 labels May 4, 2024
@dkirchan dkirchan self-assigned this May 4, 2024
@dkirchan dkirchan requested a review from a team as a code owner May 4, 2024 12:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@dkirchan dkirchan requested a review from a team May 4, 2024 12:18
@ghost
Copy link

ghost commented May 4, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dkirchan

@dkirchan dkirchan changed the title Security ftr fix [Security] Ftr API Integration tests May 6, 2024
@MadameSheema MadameSheema enabled auto-merge (squash) May 6, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants