Skip to content

Fix time picker not to show [object Object]#182152

Merged
sakurai-youhei merged 9 commits intoelastic:mainfrom
sakurai-youhei:fix-object-object-in-message
May 9, 2024
Merged

Fix time picker not to show [object Object]#182152
sakurai-youhei merged 9 commits intoelastic:mainfrom
sakurai-youhei:fix-object-object-in-message

Conversation

@sakurai-youhei
Copy link
Member

@sakurai-youhei sakurai-youhei commented Apr 30, 2024 •
edited by kibanamachine
Loading

Summary

This PR fixes one i18n mapping for EUI to render the dateFormat = MMM D, YYYY @ HH:mm:ss.SSS correctly at the bottom.

With i18n.locale: "en":
kibana-bug-fixed-en

With i18n.locale: "zh-CN":
image

With i18n.locale: "ja-JP":
kibana-bug-fixed-ja_JP

With i18n.locale: "fr-FR":
image

Note: It showed [object Object] instead of MMM D, YYYY @ HH:mm:ss.SSS before this fix.

Fixes #182099

Checklist

For maintainers

Release note

Fixes time picker to show allowed formats properly in absolute tabs.

@sakurai-youhei sakurai-youhei added bug Fixes for quality problems that affect the customer experience release_note:fix backport:prev-minor labels Apr 30, 2024
@sakurai-youhei sakurai-youhei requested a review from a team as a code owner April 30, 2024 14:32
@sakurai-youhei sakurai-youhei marked this pull request as draft April 30, 2024 15:43
@sakurai-youhei

This comment was marked as outdated.

Sign in to view
@sakurai-youhei sakurai-youhei marked this pull request as ready for review May 3, 2024 01:32
@sakurai-youhei sakurai-youhei marked this pull request as draft May 3, 2024 17:53
@sakurai-youhei sakurai-youhei marked this pull request as ready for review May 4, 2024 05:34
@pgayvallet
Copy link
Contributor

pgayvallet commented May 6, 2024

cc @Bamieh

@Bamieh Bamieh self-requested a review May 7, 2024 21:25
@Bamieh
Copy link
Contributor

Bamieh commented May 7, 2024

Weird how that passed the CI check. I need to pull the code to check tomorrow morning

@Bamieh
Copy link
Contributor

Bamieh commented May 8, 2024 •
edited
Loading

Hey,

Can you share a screenshot for the [object object]? i ran the main branch and i am getting the correct formatting.

image

Also the values object inside the code looks good.

@sakurai-youhei
Copy link
Member Author

sakurai-youhei commented May 8, 2024

Hi @Bamieh This is a screenshot from the main branch 187ed09.

sakurai@wsl:~/git/kibana$ git log -1
commit 187ed098750c68ee889f1c7c2156f41c163f262f (HEAD -> main, origin/main, origin/HEAD)
Author: Elastic Machine <elasticmachine@users.noreply.github.com>
Date:   Wed May 8 15:01:26 2024 +0100

    [main] Sync bundled packages with Package Storage (#182938)

    Automated by
    https://buildkite.com/elastic/package-storage-infra-kibana-discover-release-branches/builds/677

image

Because the dateFormat is a react component, i18n.translate() returns a string containing [object Object].

image

Bamieh
Bamieh approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you.

@Bamieh
Copy link
Contributor

Bamieh commented May 9, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented May 9, 2024

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 408.2KB 408.3KB +19.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sakurai-youhei sakurai-youhei merged commit 50d6748 into elastic:main May 9, 2024
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 9, 2024
@sakurai-youhei @kibanamachine
Fix time picker not to show [object Object] (elastic#182152)
6a9eeca 
## Summary

This PR fixes one i18n mapping for EUI to render the `dateFormat` = `MMM
D, YYYY @ HH:mm:ss.SSS` correctly at the bottom.

Note: It showed `[object Object]` instead of `MMM D, YYYY @
HH:mm:ss.SSS` before this fix.

Fixes elastic#182099

## Release note

Fixes time picker to show allowed formats properly in absolute tabs.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 50d6748)
@kibanamachine kibanamachine mentioned this pull request May 9, 2024
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented May 9, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 9, 2024
@kibanamachine @sakurai-youhei
[8.14] Fix time picker not to show &#x60;[object Object]&#x60; (#182152…
23ed120 
…) (#183022)

# Backport

This will backport the following commits from `main` to `8.14`:
- [Fix time picker not to show &#x60;[object Object]&#x60;
(#182152)](#182152)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Youhei
Sakurai","email":"youhei.sakurai@elastic.co"},"sourceCommit":{"committedDate":"2024-05-09T10:08:07Z","message":"Fix
time picker not to show `[object Object]` (#182152)\n\n##
Summary\r\n\r\nThis PR fixes one i18n mapping for EUI to render the
`dateFormat` = `MMM\r\nD, YYYY @ HH:mm:ss.SSS` correctly at the
bottom.\r\n\r\nNote: It showed `[object Object]` instead of `MMM D, YYYY
@\r\nHH:mm:ss.SSS` before this fix.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/182099\r\n\r\n## Release
note\r\n\r\nFixes time picker to show allowed formats properly in
absolute tabs.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"50d674867bdf1af37f6b61a89151e52c5da2bdbd","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-minor","v8.15.0"],"title":"Fix
time picker not to show `[object
Object]`","number":182152,"url":"https://github.com/elastic/kibana/pull/182152","mergeCommit":{"message":"Fix
time picker not to show `[object Object]` (#182152)\n\n##
Summary\r\n\r\nThis PR fixes one i18n mapping for EUI to render the
`dateFormat` = `MMM\r\nD, YYYY @ HH:mm:ss.SSS` correctly at the
bottom.\r\n\r\nNote: It showed `[object Object]` instead of `MMM D, YYYY
@\r\nHH:mm:ss.SSS` before this fix.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/182099\r\n\r\n## Release
note\r\n\r\nFixes time picker to show allowed formats properly in
absolute tabs.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"50d674867bdf1af37f6b61a89151e52c5da2bdbd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182152","number":182152,"mergeCommit":{"message":"Fix
time picker not to show `[object Object]` (#182152)\n\n##
Summary\r\n\r\nThis PR fixes one i18n mapping for EUI to render the
`dateFormat` = `MMM\r\nD, YYYY @ HH:mm:ss.SSS` correctly at the
bottom.\r\n\r\nNote: It showed `[object Object]` instead of `MMM D, YYYY
@\r\nHH:mm:ss.SSS` before this fix.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/182099\r\n\r\n## Release
note\r\n\r\nFixes time picker to show allowed formats properly in
absolute tabs.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"50d674867bdf1af37f6b61a89151e52c5da2bdbd"}}]}]
BACKPORT-->

Co-authored-by: Youhei Sakurai <youhei.sakurai@elastic.co>
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bamieh Bamieh Bamieh approved these changes

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience release_note:fix v8.14.0 v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Time picker shows [object Object] in absolute tab

5 participants

@sakurai-youhei @pgayvallet @Bamieh @kibana-ci @kibanamachine