Skip to content

Comments

[Security Serverless] - no net new capability to initiate/create investigate guides in timelines for 'essential tier' (#8700)#181562

Merged
e40pud merged 4 commits intoelastic:mainfrom
e40pud:security/serverless/8700-investigate-guides-interations
Apr 26, 2024
Merged

[Security Serverless] - no net new capability to initiate/create investigate guides in timelines for 'essential tier' (#8700)#181562
e40pud merged 4 commits intoelastic:mainfrom
e40pud:security/serverless/8700-investigate-guides-interations

Conversation

@e40pud
Copy link
Contributor

@e40pud e40pud commented Apr 24, 2024

Summary

Addresses https://github.com/elastic/security-team/issues/8700

With these changes we disable Interactive Investigation guides interactions buttons (timelines + OSquery interactive actions) for 'Essential tier' in Serverless.

For Investigation guides in the Detection rules:

Create rule page -> Advanced settings - > Investigation guide

osquery and timeline buttons should be inactive and have an upgrade callout

Screenshot 2024-04-24 at 15 08 32

Rule details page -> Investigations guide

buttons in the markdown should be inactive and have an upgrade callout

Screenshot 2024-04-24 at 15 09 07

Checklist

Delete any items that are not applicable to this PR.

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Apr 24, 2024
@e40pud e40pud self-assigned this Apr 24, 2024
@e40pud e40pud requested review from a team as code owners April 24, 2024 13:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with different product types in serverless, everything works as expected. In ESS investigation guide interactions are always available, regardless of the license type (which is a bit odd, but it's the intended behavior).

LGTM! 💯

@e40pud
Copy link
Contributor Author

e40pud commented Apr 25, 2024

@elasticmachine merge upstream

'aria-label': 'aria-label-test1',
iconType: 'logoOsquery',
isDisabled: !!interactionsUpsellingMessage,
'data-test-subj': 'test-test-test',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename or maybe remove since it appears unused?

Copy link
Contributor Author

@e40pud e40pud Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man, thanks for catching this.. was playing around with plugin and forgot to remove this line. The line 'aria-label': 'aria-label-test1', should be removed as well

Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the 1 line and lgtm 👍

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 17.3MB 17.3MB +2.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 19.1KB 19.6KB +489.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@e40pud e40pud merged commit 13a968a into elastic:main Apr 26, 2024
@kibanamachine kibanamachine added v8.15.0 backport:skip This PR does not require backporting labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants