[ES|QL] [Discover] Creating where clause filters from the table, sidebar and table row viewer #181399

stratoula · 2024-04-23T09:30:52Z

Summary

Part of #181280

This PR handles the creation of filters (where clause) in Discover ES|QL mode. The parts that are being handled are:

sidebar
document viewer
table

The creation of filters from the charts is not here.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…fix'

stratoula · 2024-04-29T11:47:46Z

/ci

elasticmachine · 2024-04-29T13:18:12Z

Pinging @elastic/kibana-esql (Team:ESQL)

jughosta

Very nice feature!

packages/kbn-esql-utils/src/utils/append_to_query.test.ts

packages/kbn-unified-data-table/src/components/__snapshots__/data_table_columns.test.tsx.snap

src/plugins/discover/public/application/main/components/layout/discover_layout.tsx

src/plugins/discover/public/application/main/components/sidebar/lib/get_field_list.ts

src/plugins/discover/public/components/doc_table/doc_table_wrapper.tsx

test/functional/apps/discover/group6/_sidebar_field_stats.ts

packages/kbn-esql-utils/src/utils/append_to_query.ts

packages/kbn-unified-data-table/src/components/data_table_columns.tsx

drewdaemon

Overall working nicely, but I think there are some corner cases to look at

packages/kbn-esql-utils/src/utils/append_to_query.ts

stratoula · 2024-05-01T12:42:59Z

/ci

drewdaemon

ES|QL stuff looks good to me. I created a couple issues to improve our query manipulation DX

drewdaemon · 2024-05-01T17:42:31Z

Lol... I guess I technically approved the whole thing since I'm a member of both Discover and ES|QL teams....

I only meant my review to be on behalf of the ES|QL team. I leave the Discover stuff to @jughosta

stratoula · 2024-05-01T20:11:17Z

Thanx Drew, I want to revert and i will def not merge without Julia's approval :D

stratoula · 2024-05-06T08:52:48Z

/ci

jughosta

The functionality looks great!

One thing before the approval: can we update the following tests? Currently they generate incorrect schemas and might be less effective in testing:
packages/kbn-unified-data-table/src/components/data_table_columns.test.tsx

packages/kbn-unified-data-table/src/components/__snapshots__/data_table_columns.test.tsx.snap

packages/kbn-unified-data-table/src/components/default_cell_actions.tsx

test/functional/apps/discover/group6/_sidebar_field_stats.ts

packages/kbn-unified-data-table/src/components/data_table_columns.tsx

stratoula · 2024-05-06T09:47:30Z

Ok so @jughosta on your comments:

simplified the code adc9d6e
fixed the tests that were not already correct in main fff036d (we were also marking extension as number which seems wrong to me, I changed it to string)
created an issue about the utility you suggested [DataViews] Create a utility to create a new ES|QL type field #182646. I think it needs a discussion first and should not be part of this PR
about the FT I get your way of thinking. I suggest to move on with one FT and if we feel it creates problems in the future we can split. I hope you are ok with it.

stratoula · 2024-05-06T09:48:04Z

/ci

jughosta

Awesome work! And thanks for addressing the comments! 🚢

stratoula · 2024-05-06T11:36:48Z

/ci

kibana-ci · 2024-05-06T12:48:43Z

💚 Build Succeeded

Buildkite Build
Commit: 8bc656e

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/esql-utils`	28	34	+6
`@kbn/unified-data-table`	83	80	-3
total			+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	422.6KB	422.6KB	+9.0B
`apm`	3.2MB	3.2MB	+14.0B
`cloudSecurityPosture`	452.2KB	452.6KB	+398.0B
`dataVisualizer`	656.1KB	656.1KB	+6.0B
`discover`	629.3KB	631.0KB	+1.8KB
`lens`	1.4MB	1.4MB	+6.0B
`logsExplorer`	317.8KB	317.8KB	+14.0B
`ml`	4.1MB	4.1MB	+7.0B
`securitySolution`	13.7MB	13.7MB	+1.9KB
`slo`	764.0KB	764.4KB	+407.0B
`unifiedHistogram`	73.2KB	73.2KB	+21.0B
total			+4.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/unified-doc-viewer`	6	5	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`aiops`	7.3KB	7.3KB	+54.0B
`apm`	34.6KB	34.6KB	+54.0B
`cloudSecurityPosture`	16.0KB	16.1KB	+139.0B
`logsExplorer`	54.3KB	54.4KB	+139.0B
`ml`	77.2KB	77.2KB	+54.0B
`slo`	23.0KB	23.1KB	+54.0B
total			+494.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/esql-utils`	30	36	+6
`@kbn/unified-data-table`	152	149	-3
total			+3

History

💔 Build #208045 failed 0d16316
💚 Build #207980 succeeded 41cb5ed
💚 Build #207395 succeeded 193e670
💛 Build #207194 was flaky 22e5a44
💔 Build #207160 failed 8c14396

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[ES|QL] Propagate the query with where clasue

4ec560b

stratoula changed the title ~~[ES|QL] Propagate the query with where clasue~~ [ES|QL] Propagate the query with where clause Apr 23, 2024

stratoula added 4 commits April 23, 2024 13:20

Take under consideration the last command

199c8b2

Merge branch 'main' into discover-create-where-filter

71b16d2

Take under cosideration the filter existence

6281901

Disable filter actions when the table is embedded

d4f6fc3

stratoula changed the title ~~[ES|QL] Propagate the query with where clause~~ [ES|QL] [Discover] Propagate the query with where clause Apr 25, 2024

kibanamachine and others added 12 commits April 25, 2024 10:50

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

07a2075

…fix'

Simplifications

c995cc0

Fixes

11639c5

Merge branch 'main' into discover-create-where-filter

ab80ffb

More fixes

dfbe8dd

Fix quotes

149c888

Fix jest tests

4cf0952

Fix jest tests

6d726f3

Merge branch 'main' into discover-create-where-filter

2d64643

Some cleanuo

92b5050

Add functional tests

deee9d4

Fix FTs

067d5d3

stratoula added backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.15.0 Feature:Discover Discover Application labels Apr 29, 2024

stratoula marked this pull request as ready for review April 29, 2024 13:18

stratoula requested review from a team as code owners April 29, 2024 13:18

stratoula changed the title ~~[ES|QL] [Discover] Propagate the query with where clause~~ [ES|QL] [Discover] Creating where clause filters from the table, sidebar and table row viewer Apr 30, 2024

jughosta reviewed Apr 30, 2024

View reviewed changes

drewdaemon reviewed Apr 30, 2024

View reviewed changes

packages/kbn-esql-utils/src/utils/append_to_query.ts Show resolved Hide resolved

packages/kbn-esql-utils/src/utils/append_to_query.ts Show resolved Hide resolved

packages/kbn-esql-utils/src/utils/append_to_query.ts Outdated Show resolved Hide resolved

stratoula added 5 commits May 1, 2024 08:49

Merge with main and resolve conflicts

aa0e9fa

Address some of the comments

a6ddb09

Fix case bug

aca8198

Use recursive function

8c14396

Merge branch 'main' into discover-create-where-filter

22e5a44

drewdaemon approved these changes May 1, 2024

View reviewed changes

stratoula added 5 commits May 2, 2024 07:52

Merge branch 'main' into discover-create-where-filter

9142030

Revert implememtation and rely on regex

ebad482

Do not append if filter is not null already exists

193e670

Merge branch 'main' into discover-create-where-filter

41cb5ed

Merge branch 'main' into discover-create-where-filter

4dc57a9

jughosta reviewed May 6, 2024

View reviewed changes

stratoula added 3 commits May 6, 2024 11:23

Correct existing wrong Discover tests

fff036d

Pass the correct type for the extension in the test

adc9d6e

Simoplification

0d16316

jughosta approved these changes May 6, 2024

View reviewed changes

Update jest test

8bc656e

stratoula merged commit b64500b into elastic:main May 6, 2024
17 checks passed

drewdaemon mentioned this pull request May 28, 2024

[ES|QL] AST traversal API #182255

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] [Discover] Creating where clause filters from the table, sidebar and table row viewer #181399

[ES|QL] [Discover] Creating where clause filters from the table, sidebar and table row viewer #181399

stratoula commented Apr 23, 2024 •

edited

Loading

stratoula commented Apr 29, 2024

elasticmachine commented Apr 29, 2024

jughosta left a comment

drewdaemon left a comment

stratoula commented May 1, 2024

drewdaemon left a comment •

edited

Loading

drewdaemon commented May 1, 2024

stratoula commented May 1, 2024

stratoula commented May 6, 2024

jughosta left a comment

stratoula commented May 6, 2024 •

edited

Loading

stratoula commented May 6, 2024

jughosta left a comment

stratoula commented May 6, 2024

kibana-ci commented May 6, 2024

API count

[ES|QL] [Discover] Creating where clause filters from the table, sidebar and table row viewer #181399

[ES|QL] [Discover] Creating where clause filters from the table, sidebar and table row viewer #181399

Conversation

stratoula commented Apr 23, 2024 • edited Loading

Summary

Checklist

stratoula commented Apr 29, 2024

elasticmachine commented Apr 29, 2024

jughosta left a comment

Choose a reason for hiding this comment

drewdaemon left a comment

Choose a reason for hiding this comment

stratoula commented May 1, 2024

drewdaemon left a comment • edited Loading

Choose a reason for hiding this comment

drewdaemon commented May 1, 2024

stratoula commented May 1, 2024

stratoula commented May 6, 2024

jughosta left a comment

Choose a reason for hiding this comment

stratoula commented May 6, 2024 • edited Loading

stratoula commented May 6, 2024

jughosta left a comment

Choose a reason for hiding this comment

stratoula commented May 6, 2024

kibana-ci commented May 6, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

History

stratoula commented Apr 23, 2024 •

edited

Loading

drewdaemon left a comment •

edited

Loading

stratoula commented May 6, 2024 •

edited

Loading