-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Fleet] Expose agent logging level in agent policy settings #180607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
criamico
merged 12 commits into
elastic:main
from
criamico:158861_logging_level_per_policy
Apr 15, 2024
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
54f48e6
[Fleet] Expose agent logging level in agent policy settings
criamico 88fd21f
Fix types
criamico d2f3103
Add feature flag and unit tests
criamico 2c0a1f9
Fix submit policy and remove leftover props
criamico 631ca5d
Merge branch 'main' into 158861_logging_level_per_policy
kibanamachine a3c6e25
Move logging level select under advanced features section
criamico e0ab64a
Merge main and solve conflicts
criamico 08ab938
Remove unused types
criamico 215dad6
Merge branch 'main' into 158861_logging_level_per_policy
kibanamachine fbd1788
Address code review comments
criamico 093194d
Fix linter and error in UI
criamico b3657ac
set hidden to true
criamico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,15 +63,13 @@ interface Props { | |
| agentPolicy: Partial<NewAgentPolicy | AgentPolicy>; | ||
| updateAgentPolicy: (u: Partial<NewAgentPolicy | AgentPolicy>) => void; | ||
| validation: ValidationResults; | ||
| isEditing?: boolean; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This field was not used anymore so I removed it |
||
| disabled?: boolean; | ||
| } | ||
|
|
||
| export const AgentPolicyAdvancedOptionsContent: React.FunctionComponent<Props> = ({ | ||
| agentPolicy, | ||
| updateAgentPolicy, | ||
| validation, | ||
| isEditing = false, | ||
| disabled = false, | ||
| }) => { | ||
| const { docLinks } = useStartServices(); | ||
|
|
@@ -401,7 +399,6 @@ export const AgentPolicyAdvancedOptionsContent: React.FunctionComponent<Props> = | |
| }} | ||
| /> | ||
| </EuiDescribedFormGroup> | ||
|
|
||
| {AgentTamperProtectionSection} | ||
|
|
||
| <EuiDescribedFormGroup | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,8 +35,6 @@ interface Props { | |
| withSysMonitoring: boolean; | ||
| updateSysMonitoring: (newValue: boolean) => void; | ||
| validation: ValidationResults; | ||
| isEditing?: boolean; | ||
| onDelete?: () => void; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, the linter catched unused props |
||
| } | ||
|
|
||
| export const AgentPolicyIntegrationForm: React.FunctionComponent<Props> = ({ | ||
|
|
@@ -45,8 +43,6 @@ export const AgentPolicyIntegrationForm: React.FunctionComponent<Props> = ({ | |
| withSysMonitoring, | ||
| updateSysMonitoring, | ||
| validation, | ||
| isEditing = false, | ||
| onDelete = () => {}, | ||
| }) => { | ||
| return ( | ||
| <EuiForm> | ||
|
|
@@ -101,7 +97,6 @@ export const AgentPolicyIntegrationForm: React.FunctionComponent<Props> = ({ | |
| agentPolicy={agentPolicy} | ||
| updateAgentPolicy={updateAgentPolicy} | ||
| validation={validation} | ||
| isEditing={isEditing} | ||
| /> | ||
| </StyledEuiAccordion> | ||
| </> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.