Skip to content

[ML] Unskip a11y tests and fix datavisualizer test #179833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peteharverson merged 1 commit into from
Apr 2, 2024
Merged

[ML] Unskip a11y tests and fix datavisualizer test #179833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions x-pack/plugins/ml/public/application/datavisualizer/datavisualizer_selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
EuiTextAlign,
} from '@elastic/eui';

import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import { useTimefilter } from '@kbn/ml-date-picker';
import { isFullLicense } from '../license';
Expand Down Expand Up @@ -182,6 +183,12 @@ export const DatavisualizerSelector: FC = () => {
/>
}
tooltipPosition={'right'}
aria-label={i18n.translate(
'xpack.ml.datavisualizer.selector.technicalPreviewBadge.ariaLabel',
{
defaultMessage: 'ES|QL is in technical preview.',
}
)}
/>
</>
</EuiTextAlign>
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/accessibility/apps/group2/ml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ export default function ({ getService }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/172598
describe.skip('with data loaded', function () {
describe('with data loaded', function () {
const dfaOutlierResultsJobId = 'iph_outlier_a11y';
const ecIndexName = 'ft_module_sample_ecommerce';
const ihpIndexName = 'ft_ihp_outlier';
Expand Down