[8.13] fix: [Rules > Shared exception lists][AXE-CORE]: Interactive controls must not be nested (#178023)#178754
Merged
kibanamachine merged 1 commit intoelastic:8.13from Mar 14, 2024
Conversation
… must not be nested (elastic#178023) Closes: elastic/security-team#8611 ## Description The [axe browser plugin](https://deque.com/axe) is reporting a nested button (interactive control)in the shared exception list accordion(s). The accordion has a button to open/close and a link to the list detail view. Screenshot attached below. ### Steps to recreate 1. Open the Security Dashboards, then click Rules > Shared Exception Lists 2. Run an axe browser scan in Chrome, Edge, or Firefox 3. Verify the nested control error ### What was done? 1. Solution proposed by EUI team was applied. See elastic/eui#7545 2. The component `ExceptionsListCard` has been slightly changed to make it more responsive. Before: After: https://github.com/elastic/kibana/assets/20072247/dd6c6681-980c-40ed-98cf-29a71f896bc2 ### Screen #### AXE Report  (cherry picked from commit b90e215)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @alexwizp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.13:Questions ?
Please refer to the Backport tool documentation