Skip to content

Upgrade EUI to v93.3.0#178438

Merged
cee-chen merged 2 commits intoelastic:mainfrom
cee-chen:eui/v93.3.0
Mar 12, 2024
Merged

Upgrade EUI to v93.3.0#178438
cee-chen merged 2 commits intoelastic:mainfrom
cee-chen:eui/v93.3.0

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Mar 11, 2024

v93.2.0v93.3.0


v93.3.0

  • Added new EuiDataGrid new prop: cellContext, an optional object of additional props passed to the cell render function. (#7374)
  • EuiBreadcrumbs's popoverContent API now accepts a render function that will be passed a closePopover callback, allowing consumers to close the breadcrumb popover from their popover content (#7555)

Bug fixes

  • Fixed missing animation on native EuiProgress bar update (#7538)
  • Fixed an EuiDataGrid bug with gridStyle.rowClasses, where custom consumer classes that began with euiDataGridRow would not be correctly removed/reapplied (#7549)
  • Fixed a visual EuiDataGrid bug where EuiCheckboxes within control columns were not vertically centered within single height rows (#7549)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.14.0 labels Mar 11, 2024
@cee-chen
Copy link
Copy Markdown
Contributor Author

/ci

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/cases_api_integration/security_and_spaces/config_trial.ts / cases security and spaces enabled: trial push_case memoryless server pushes a comment appropriately

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.4MB 1.4MB +2.0KB
kubernetesSecurity 208.1KB 210.0KB +2.0KB
maps 2.9MB 2.9MB +1.9KB
visTypeVega 1.8MB 1.8MB +2.0KB
total +7.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 273.6KB 273.7KB +119.0B
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +1.9KB
total +2.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review March 12, 2024 02:48
@cee-chen cee-chen requested review from a team as code owners March 12, 2024 02:48
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 👍

@kc13greiner kc13greiner self-requested a review March 12, 2024 12:00
Copy link
Copy Markdown
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas snapshot changes LGTM 👍

Copy link
Copy Markdown
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vislib changes LGTM

@cee-chen
Copy link
Copy Markdown
Contributor Author

Thanks y'all for the speedy reviews! 💖

@cee-chen cee-chen merged commit 142df27 into elastic:main Mar 12, 2024
@cee-chen cee-chen deleted the eui/v93.3.0 branch March 12, 2024 16:06
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants