[Cases] Unskip filter popover, property actions flaky tests #177611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-jankisalvi
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
adcoelho
approved these changes
Feb 22, 2024
Contributor
There was a problem hiding this comment.
Approved, no need to do this but I was thinking about the following:
Tiago mentioned in our call Tuesday that some tests are async when they shouldn't be.
I found a few in the files in this PR:
alert_property_actions.test.tsx- line 86
registered_attachments_property_actions.test.tsx- line 88
- line 95
user_comment_property_actions.test.tsx- line 101
Contributor
Author
Yeah I was thinking this and then thought let's first see if current changes are working or not. 😄 |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…177611) ## Summary As a follow-up to elastic#176863 unskipping filterPopOver and propertyActions tests Fixes elastic#176679 Fixes elastic#176680 Fixes elastic#176681 Fixes elastic#176682 Fixes elastic#176683 Fixes elastic#176684 Fixes elastic#176685 Fixes elastic#176686 Fixes elastic#174384 Fixes elastic#174667 Fixes elastic#175310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a follow-up to #176863 unskipping filterPopOver and propertyActions tests
Fixes #176679
Fixes #176680
Fixes #176681
Fixes #176682
Fixes #176683
Fixes #176684
Fixes #176685
Fixes #176686
Fixes #174384
Fixes #174667
Fixes #175310