Skip to content

[8.13] [Security Solution] Fix cell actions in Explore pages (#177478) #177501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Feb 21, 2024
Merged

[8.13] [Security Solution] Fix cell actions in Explore pages (#177478) #177501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions x-pack/packages/security-solution/data_table/components/data_table/helpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,25 +85,13 @@ export const mapSortingColumns = ({
export const addBuildingBlockStyle = (
ecs: Ecs,
theme: EuiTheme,
setCellProps: EuiDataGridCellValueElementProps['setCellProps'],
defaultStyles?: React.CSSProperties
setCellProps: EuiDataGridCellValueElementProps['setCellProps']
) => {
const currentStyles = defaultStyles ?? {};
if (isEventBuildingBlockType(ecs)) {
setCellProps({
style: {
...currentStyles,
backgroundColor: `${theme.eui.euiColorHighlight}`,
},
});
setCellProps({ style: { backgroundColor: `${theme.eui.euiColorHighlight}` } });
} else {
// reset cell style
setCellProps({
style: {
...currentStyles,
backgroundColor: 'inherit',
},
});
setCellProps({ style: { backgroundColor: 'inherit' } });
}
};

Expand Down
4 changes: 1 addition & 3 deletions x-pack/packages/security-solution/data_table/components/data_table/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,8 @@ export const DataTableComponent = React.memo<DataTableProps>(
const ecs = pageRowIndex < data.length ? data[pageRowIndex].ecs : null;

useEffect(() => {
const defaultStyles = { overflow: 'hidden' };
setCellProps({ style: { ...defaultStyles } });
if (ecs && rowData) {
addBuildingBlockStyle(ecs, theme, setCellProps, defaultStyles);
addBuildingBlockStyle(ecs, theme, setCellProps);
} else {
// disable the cell when it has no data
setCellProps({ style: { display: 'none' } });
Expand Down