Skip to content

Comments

Upgrade EUI to v93.2.0#177361

Merged
jbudz merged 6 commits intoelastic:mainfrom
cee-chen:eui/v93.2.0
Feb 23, 2024
Merged

Upgrade EUI to v93.2.0#177361
jbudz merged 6 commits intoelastic:mainfrom
cee-chen:eui/v93.2.0

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Feb 20, 2024

v93.1.1⏩ v93.2.0

  • Updated EuiPageSidebar and EuiPageTemplate.Sidebar with a new hasEmbellish prop (defaults to false) (#7521)
  • Added diff glyph to EuiIcon (#7520)
  • Added newChat glyph to EuiIcon (#7524)

Bug fixes

  • Fixed EuiSideNav not correctly typing the items prop as required (#7521)
  • Fixed the CSS is not defined bug in EuiPageTemplate when rendering in some SSR environments, particularly Next.js v13 and up (#7525)
  • Fixed EuiDataGrid component to clean up timer from side effect on unmount (#7534)

Accessibility

  • Fixed EuiSideNav to render a fallback aria-label on mobile toggles if no heading or mobile title exists (#7521)

CSS-in-JS conversions

  • Converted EuiSideNav to Emotion; Removed the following Sass variables: (#7521)
    • $euiSideNavEmphasizedBackgroundColor
    • $euiSideNavRootTextcolor
    • $euiSideNavBranchTextcolor
    • $euiSideNavSelectedTextcolor
    • $euiSideNavDisabledTextcolor
  • Removed the euiSideNavEmbellish Sass mixin. Use the new EuiPageSidebar hasEmbellish prop instead (#7521)
  • Added a new memoization/performance optimization utility for CSS-in-JS styles (#7529)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.14.0 ci:build-webpack-bundle-analyzer labels Feb 20, 2024
@cee-chen cee-chen force-pushed the eui/v93.2.0 branch 3 times, most recently from 5036294 to 8fe805c Compare February 20, 2024 22:35
@cee-chen
[EuiSideNav] Remove Sass mixin and replace with hasEmbellish prop
6d55aa3 
- for the medium breakpoint/collapsed EuiFlyout usage, this requires nesting an `EuiPageSidebar` in the flyout

- also requires some extra Security CSS selector tweaks
@cee-chen
Copy link
Contributor Author

cee-chen commented Feb 21, 2024

/ci

@cee-chen cee-chen marked this pull request as ready for review February 21, 2024 20:02
@cee-chen cee-chen requested review from a team as code owners February 21, 2024 20:02
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 21, 2024

Pinging @elastic/eui-team (EUI)

tsullivan
tsullivan approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a question/nit in solution_nav.tsx

@cee-chen
Copy link
Contributor Author

cee-chen commented Feb 23, 2024

@elastic/security-solution Going to skip approval from your team and request for an admin merge by EOD. Side nav changes have been QA'd by someone from the design team and Shared UX team and should not contain any UI regressions pertaining your solution. If you find that to not be the case post-merge, please feel free to ping our team any time!

rylnd
rylnd approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a quick click-through and things look fine, but mainly leaning on existing QA approval here.

Approving in the hopes of saving you the trouble of working around the merge gates.

@cee-chen
Copy link
Contributor Author

cee-chen commented Feb 23, 2024

Thanks @rylnd, you rock! A quick click-through is perfect - basically if your solution side nav doesn't look wonky, everything should be shipshape!

@cee-chen cee-chen enabled auto-merge (squash) February 23, 2024 21:03
@kibana-ci
Copy link

kibana-ci commented Feb 23, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / CustomFields renders correctly
  • [job] [logs] Jest Tests #8 / RegisteredAttachmentsPropertyActions renders the correct number of actions

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1429 1430 +1
kubernetesSecurity 198 199 +1
maps 1145 1146 +1
visTypeVega 308 309 +1
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1015.3KB 1015.2KB -107.0B
dashboard 383.9KB 383.7KB -107.0B
dataViewManagement 137.9KB 137.8KB -150.0B
discover 580.3KB 580.1KB -150.0B
enterpriseSearch 2.7MB 2.7MB -106.0B
eventAnnotationListing 198.4KB 198.3KB -107.0B
filesManagement 90.8KB 90.7KB -107.0B
graph 388.0KB 387.9KB -107.0B
home 137.7KB 137.6KB -107.0B
indexManagement 594.0KB 593.9KB -107.0B
infra 1.4MB 1.4MB +2.7KB
kibanaOverview 51.9KB 51.8KB -107.0B
kubernetesSecurity 205.1KB 207.9KB +2.8KB
lens 1.4MB 1.4MB -150.0B
management 43.4KB 43.3KB -107.0B
maps 2.9MB 2.9MB +2.7KB
metricsDataAccess 84.6KB 84.5KB -107.0B
ml 3.7MB 3.7MB -107.0B
observabilityShared 54.8KB 54.7KB -107.0B
osquery 1.0MB 1.0MB -107.0B
security 579.8KB 579.7KB -107.0B
securitySolution 13.0MB 13.0MB -167.0B
securitySolutionEss 39.7KB 39.6KB -107.0B
securitySolutionServerless 183.5KB 183.4KB -107.0B
serverlessSearch 451.5KB 451.5KB +1.0B
spaces 175.2KB 175.1KB -107.0B
visTypeVega 1.8MB 1.8MB +2.8KB
visualizations 274.5KB 274.4KB -107.0B
total +8.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 385.4KB 385.6KB +130.0B
esUiShared 156.1KB 156.0KB -107.0B
kbnUiSharedDeps-css 280.1KB 273.6KB -6.5KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +7.9KB
kbnUiSharedDeps-srcJs 2.9MB 2.9MB -1.0B
kibanaReact 40.5KB 40.3KB -250.0B
total +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz disabled auto-merge February 23, 2024 21:40
@jbudz
Copy link
Contributor

jbudz commented Feb 23, 2024

The failing tests are both known to be flaky. Merging now.

@jbudz jbudz merged commit 7481923 into elastic:main Feb 23, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Feb 23, 2024
semd pushed a commit to semd/kibana that referenced this pull request Mar 4, 2024
@cee-chen @semd
Upgrade EUI to v93.2.0 (elastic#177361)
192c681 
`v93.1.1`⏩ `v93.2.0`

---

- Updated `EuiPageSidebar` and `EuiPageTemplate.Sidebar` with a new
`hasEmbellish` prop (defaults to false)
([elastic#7521](elastic/eui#7521))
- Added `diff` glyph to `EuiIcon`
([elastic#7520](elastic/eui#7520))
- Added `newChat` glyph to `EuiIcon`
([elastic#7524](elastic/eui#7524))

**Bug fixes**

- Fixed `EuiSideNav` not correctly typing the `items` prop as required
([elastic#7521](elastic/eui#7521))
- Fixed the `CSS is not defined` bug in `EuiPageTemplate` when rendering
in some SSR environments, particularly Next.js v13 and up
([elastic#7525](elastic/eui#7525))
- Fixed `EuiDataGrid` component to clean up timer from side effect on
unmount ([elastic#7534](elastic/eui#7534))

**Accessibility**

- Fixed `EuiSideNav` to render a fallback aria-label on mobile toggles
if no heading or mobile title exists
([elastic#7521](elastic/eui#7521))

**CSS-in-JS conversions**

- Converted `EuiSideNav` to Emotion; Removed the following Sass
variables: ([elastic#7521](elastic/eui#7521))
  - `$euiSideNavEmphasizedBackgroundColor`
  - `$euiSideNavRootTextcolor`
  - `$euiSideNavBranchTextcolor`
  - `$euiSideNavSelectedTextcolor`
  - `$euiSideNavDisabledTextcolor`
- Removed the `euiSideNavEmbellish` Sass mixin. Use the new
`EuiPageSidebar` `hasEmbellish` prop instead
([elastic#7521](elastic/eui#7521))
- Added a new memoization/performance optimization utility for CSS-in-JS
styles ([elastic#7529](elastic/eui#7529))
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@cee-chen @fkanout
Upgrade EUI to v93.2.0 (elastic#177361)
b761b46 
`v93.1.1`⏩ `v93.2.0`

---

- Updated `EuiPageSidebar` and `EuiPageTemplate.Sidebar` with a new
`hasEmbellish` prop (defaults to false)
([elastic#7521](elastic/eui#7521))
- Added `diff` glyph to `EuiIcon`
([elastic#7520](elastic/eui#7520))
- Added `newChat` glyph to `EuiIcon`
([elastic#7524](elastic/eui#7524))

**Bug fixes**

- Fixed `EuiSideNav` not correctly typing the `items` prop as required
([elastic#7521](elastic/eui#7521))
- Fixed the `CSS is not defined` bug in `EuiPageTemplate` when rendering
in some SSR environments, particularly Next.js v13 and up
([elastic#7525](elastic/eui#7525))
- Fixed `EuiDataGrid` component to clean up timer from side effect on
unmount ([elastic#7534](elastic/eui#7534))

**Accessibility**

- Fixed `EuiSideNav` to render a fallback aria-label on mobile toggles
if no heading or mobile title exists
([elastic#7521](elastic/eui#7521))

**CSS-in-JS conversions**

- Converted `EuiSideNav` to Emotion; Removed the following Sass
variables: ([elastic#7521](elastic/eui#7521))
  - `$euiSideNavEmphasizedBackgroundColor`
  - `$euiSideNavRootTextcolor`
  - `$euiSideNavBranchTextcolor`
  - `$euiSideNavSelectedTextcolor`
  - `$euiSideNavDisabledTextcolor`
- Removed the `euiSideNavEmbellish` Sass mixin. Use the new
`EuiPageSidebar` `hasEmbellish` prop instead
([elastic#7521](elastic/eui#7521))
- Added a new memoization/performance optimization utility for CSS-in-JS
styles ([elastic#7529](elastic/eui#7529))
@cee-chen cee-chen deleted the eui/v93.2.0 branch March 6, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@rylnd rylnd rylnd approved these changes

@tsullivan tsullivan tsullivan approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@cee-chen @elasticmachine @kibana-ci @jbudz @ryankeairns @rylnd @tsullivan @pgayvallet @Ikuni17 @kibanamachine