[Security Solution] [Sourcerer] Make use of reselect in sourcerer selectors #176916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqualters-elastic
added
release_note:skip
Contributor
Author
|
/ci |
semd
reviewed
Feb 15, 2024
x-pack/plugins/security_solution/public/common/containers/sourcerer/index.tsx
Show resolved
Hide resolved
…nto sourcerer-selectors-new-style
Comment on lines
+112
to
+121
| sourcerer: { | ||
| ...mockGlobalState.sourcerer, | ||
| sourcererScopes: { | ||
| ...mockGlobalState.sourcerer.sourcererScopes, | ||
| analyzer: { | ||
| ...mockGlobalState.sourcerer.sourcererScopes.default, | ||
| selectedPatterns: indices, | ||
| }, | ||
| }, | ||
| }, |
PhilippeOberti
approved these changes
Feb 15, 2024
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
the code LGTM and I smoke tested the application
semd
approved these changes
Feb 19, 2024
...lugins/security_solution/public/explore/network/components/embeddables/embedded_map.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/timelines/hooks/use_create_timeline.tsx
Show resolved
Hide resolved
Contributor
|
It looks great, thanks @kqualters-elastic ! |
nkhristinin
approved these changes
Feb 20, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
andrew-goldstein
approved these changes
Feb 23, 2024
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…ectors (elastic#176916) ## Summary This pr should change nothing functionally, but changes the selectors used in components for sourcerer to make use of createSelector and benefit from memoization at all times,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr should change nothing functionally, but changes the selectors used in components for sourcerer to make use of createSelector and benefit from memoization at all times,