[Security Solution] Disable installation button for users with Security:Read privileges #176598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty:Read privilege
jpdjere
added
release_note:fix
Team:Detections and Resp
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jpdjere |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 9, 2024
…ty:Read privileges (elastic#176598) Fixes: elastic#161543 ## Summary Original bug issue reported an infinite loading state in the **Add Elastic rules** page when user doesn't have write privileges, i.e. has `Security: Read`. However, that seems to have been fixed already, as the list of rules to install is shown, but no individual "Install button" for each row is showed. **This is expected behaviour**.  However, when displaying the Rule Details flyout, the button for Installation in the flyout is still enabled due to missing checks. This PR fixes that and now displays a disabled button for users with no privileges.  ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit c3c1b66)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 9, 2024
… Security:Read privileges (#176598) (#176616) # Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Disable installation button for users with Security:Read privileges (#176598)](#176598) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-09T16:47:13Z","message":"[Security Solution] Disable installation button for users with Security:Read privileges (#176598)\n\nFixes: https://github.com/elastic/kibana/issues/161543\r\n\r\n## Summary\r\n\r\nOriginal bug issue reported an infinite loading state in the **Add\r\nElastic rules** page when user doesn't have write privileges, i.e. has\r\n`Security: Read`.\r\n\r\nHowever, that seems to have been fixed already, as the list of rules to\r\ninstall is shown, but no individual \"Install button\" for each row is\r\nshowed. **This is expected behaviour**.\r\n\r\n\r\n\r\n\r\nHowever, when displaying the Rule Details flyout, the button for\r\nInstallation in the flyout is still enabled due to missing checks. This\r\nPR fixes that and now displays a disabled button for users with no\r\nprivileges.\r\n\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"c3c1b667c1de1aa36955528098ce0be15e7272b1","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.12.0","8.13 candidate","v8.13.0"],"title":"[Security Solution] Disable installation button for users with Security:Read privileges","number":176598,"url":"https://github.com/elastic/kibana/pull/176598","mergeCommit":{"message":"[Security Solution] Disable installation button for users with Security:Read privileges (#176598)\n\nFixes: https://github.com/elastic/kibana/issues/161543\r\n\r\n## Summary\r\n\r\nOriginal bug issue reported an infinite loading state in the **Add\r\nElastic rules** page when user doesn't have write privileges, i.e. has\r\n`Security: Read`.\r\n\r\nHowever, that seems to have been fixed already, as the list of rules to\r\ninstall is shown, but no individual \"Install button\" for each row is\r\nshowed. **This is expected behaviour**.\r\n\r\n\r\n\r\n\r\nHowever, when displaying the Rule Details flyout, the button for\r\nInstallation in the flyout is still enabled due to missing checks. This\r\nPR fixes that and now displays a disabled button for users with no\r\nprivileges.\r\n\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"c3c1b667c1de1aa36955528098ce0be15e7272b1"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176598","number":176598,"mergeCommit":{"message":"[Security Solution] Disable installation button for users with Security:Read privileges (#176598)\n\nFixes: https://github.com/elastic/kibana/issues/161543\r\n\r\n## Summary\r\n\r\nOriginal bug issue reported an infinite loading state in the **Add\r\nElastic rules** page when user doesn't have write privileges, i.e. has\r\n`Security: Read`.\r\n\r\nHowever, that seems to have been fixed already, as the list of rules to\r\ninstall is shown, but no individual \"Install button\" for each row is\r\nshowed. **This is expected behaviour**.\r\n\r\n\r\n\r\n\r\nHowever, when displaying the Rule Details flyout, the button for\r\nInstallation in the flyout is still enabled due to missing checks. This\r\nPR fixes that and now displays a disabled button for users with no\r\nprivileges.\r\n\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"c3c1b667c1de1aa36955528098ce0be15e7272b1"}}]}] BACKPORT--> Co-authored-by: Juan Pablo Djeredjian <[email protected]>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…ty:Read privileges (elastic#176598) Fixes: elastic#161543 ## Summary Original bug issue reported an infinite loading state in the **Add Elastic rules** page when user doesn't have write privileges, i.e. has `Security: Read`. However, that seems to have been fixed already, as the list of rules to install is shown, but no individual "Install button" for each row is showed. **This is expected behaviour**.  However, when displaying the Rule Details flyout, the button for Installation in the flyout is still enabled due to missing checks. This PR fixes that and now displays a disabled button for users with no privileges.  ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…ty:Read privileges (elastic#176598) Fixes: elastic#161543 ## Summary Original bug issue reported an infinite loading state in the **Add Elastic rules** page when user doesn't have write privileges, i.e. has `Security: Read`. However, that seems to have been fixed already, as the list of rules to install is shown, but no individual "Install button" for each row is showed. **This is expected behaviour**.  However, when displaying the Rule Details flyout, the button for Installation in the flyout is still enabled due to missing checks. This PR fixes that and now displays a disabled button for users with no privileges.  ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #161543
Summary
Original bug issue reported an infinite loading state in the Add Elastic rules page when user doesn't have write privileges, i.e. has
Security: Read.However, that seems to have been fixed already, as the list of rules to install is shown, but no individual "Install button" for each row is showed. This is expected behaviour.
However, when displaying the Rule Details flyout, the button for Installation in the flyout is still enabled due to missing checks. This PR fixes that and now displays a disabled button for users with no privileges.
For maintainers