Skip to content

[Lens] Fix flaky serverless tests in group 3 #176423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickofthyme merged 6 commits into from
Feb 8, 2024
Merged

[Lens] Fix flaky serverless tests in group 3 #176423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
672fe0f
unskip test for testing errors
nickofthyme Feb 7, 2024
faa4417
add missing property to serverless fn tests
nickofthyme Feb 7, 2024
d54b730
add changes to color property
nickofthyme Feb 7, 2024
17e9c8b
apply test changes since skip was applied
nickofthyme Feb 7, 2024
7aa5ee0
Merge branch 'main' into fix-flaky-g2-tests
nickofthyme Feb 7, 2024
f51f717
remove unused fnt service
nickofthyme Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/test_serverless/functional/test_suites/common/visualizations/group2/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import { FtrProviderContext } from '../../../../ftr_provider_context';
export default ({ loadTestFile, getPageObject }: FtrProviderContext) => {
const svlCommonPage = getPageObject('svlCommonPage');

// FLAKY: https://github.com/elastic/kibana/issues/168985
describe.skip('Visualizations - Group 2', function () {
describe('Visualizations - Group 2', function () {
before(async () => {
await svlCommonPage.login();
});
Expand Down
11 changes: 10 additions & 1 deletion ...erless/functional/test_suites/common/visualizations/group2/open_in_lens/agg_based/goal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '140.05%',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingBar: true,
showingTrendline: false,
},
Expand Down Expand Up @@ -78,6 +79,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '131,040,360.81%',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingBar: true,
showingTrendline: false,
},
Expand Down Expand Up @@ -106,6 +108,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '14.37%',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingBar: true,
showingTrendline: false,
},
Expand Down Expand Up @@ -134,6 +137,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,228,964,670.613',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingTrendline: false,
showingBar: true,
},
Expand All @@ -143,6 +147,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,186,695,551.251',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingTrendline: false,
showingBar: true,
},
Expand All @@ -152,6 +157,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,073,190,186.423',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingTrendline: false,
showingBar: true,
},
Expand All @@ -161,6 +167,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,031,579,645.108',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingTrendline: false,
showingBar: true,
},
Expand All @@ -170,6 +177,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,009,497,206.823',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingTrendline: false,
showingBar: true,
},
Expand All @@ -178,7 +186,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
subtitle: undefined,
extraText: undefined,
value: undefined,
color: 'rgba(0, 0, 0, 0)',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingTrendline: false,
showingBar: true,
},
Expand Down
11 changes: 10 additions & 1 deletion ...less/functional/test_suites/common/visualizations/group2/open_in_lens/agg_based/metric.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '14,005',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand All @@ -73,6 +74,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,104,036,080.615',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand Down Expand Up @@ -100,6 +102,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '1,437',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand Down Expand Up @@ -131,6 +134,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,228,964,670.613',
color: 'rgba(165, 0, 38, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand All @@ -140,6 +144,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,186,695,551.251',
color: 'rgba(253, 191, 111, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand All @@ -149,6 +154,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,073,190,186.423',
color: 'rgba(183, 224, 117, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand All @@ -158,6 +164,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,031,579,645.108',
color: 'rgba(183, 224, 117, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand All @@ -167,6 +174,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
extraText: '',
value: '13,009,497,206.823',
color: 'rgba(183, 224, 117, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand All @@ -175,7 +183,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
subtitle: undefined,
extraText: undefined,
value: undefined,
color: 'rgba(0, 0, 0, 0)',
color: 'rgba(255, 255, 255, 1)',
trendlineColor: undefined,
showingBar: false,
showingTrendline: false,
},
Expand Down
11 changes: 7 additions & 4 deletions ...rless/functional/test_suites/common/visualizations/group2/open_in_lens/agg_based/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const panelActions = getService('dashboardPanelActions');
const kibanaServer = getService('kibanaServer');
const comboBox = getService('comboBox');

describe('Table', function describeIndexTests() {
const fixture =
Expand Down Expand Up @@ -67,8 +68,9 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
expect(await dimensions[0].getVisibleText()).to.be('Average machine.ram');

await lens.openDimensionEditor('lnsDatatable_metrics > lns-dimensionTrigger');
const summaryRowFunction = await testSubjects.find('lnsDatatable_summaryrow_function');
expect(await summaryRowFunction.getVisibleText()).to.be('Sum');
expect(await comboBox.getComboBoxSelectedOptions('lnsDatatable_summaryrow_function')).to.eql([
'Sum',
]);
});

it('should convert sibling pipeline aggregation', async () => {
Expand Down Expand Up @@ -132,8 +134,9 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const percentageColumnText = await lens.getDimensionTriggerText('lnsDatatable_metrics', 1);

await lens.openDimensionEditor('lnsDatatable_metrics > lns-dimensionTrigger', 0, 1);
const format = await testSubjects.find('indexPattern-dimension-format');
expect(await format.getVisibleText()).to.be('Percent');
expect(await comboBox.getComboBoxSelectedOptions('indexPattern-dimension-format')).to.eql([
'Percent',
]);

const dimensions = await testSubjects.findAll('lns-dimensionTrigger');
expect(dimensions).to.have.length(2);
Expand Down
8 changes: 4 additions & 4 deletions ...serverless/functional/test_suites/common/visualizations/group3/open_in_lens/tsvb/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const retry = getService('retry');
const panelActions = getService('dashboardPanelActions');
const kibanaServer = getService('kibanaServer');
const comboBox = getService('comboBox');

describe('Table', function describeIndexTests() {
const fixture =
Expand Down Expand Up @@ -84,9 +83,10 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

await lens.openDimensionEditor('lnsDatatable_metrics > lns-dimensionTrigger');
await testSubjects.click('indexPattern-advanced-accordion');
expect(
await comboBox.getComboBoxSelectedOptions('indexPattern-dimension-reducedTimeRange')
).to.eql(['1 minute (1m)']);
const reducedTimeRange = await testSubjects.find(
'indexPattern-dimension-reducedTimeRange > comboBoxSearchInput'
);
expect(await reducedTimeRange.getAttribute('value')).to.be('1 minute (1m)');

await retry.try(async () => {
const layerCount = await lens.getLayerCount();
Expand Down
7 changes: 4 additions & 3 deletions ...serverless/functional/test_suites/common/visualizations/group3/open_in_lens/tsvb/top_n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const queryBar = getService('queryBar');
const panelActions = getService('dashboardPanelActions');
const kibanaServer = getService('kibanaServer');
const comboBox = getService('comboBox');

describe('Top N', function describeIndexTests() {
const fixture =
Expand Down Expand Up @@ -102,8 +101,10 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

await lens.openDimensionEditor('lnsXY_yDimensionPanel > lns-dimensionTrigger');
await testSubjects.click('indexPattern-advanced-accordion');
const reducedTimeRange = await testSubjects.find('indexPattern-dimension-reducedTimeRange');
await comboBox.isOptionSelected(reducedTimeRange, '1 minute (1m)');
const reducedTimeRange = await testSubjects.find(
'indexPattern-dimension-reducedTimeRange > comboBoxSearchInput'
);
expect(await reducedTimeRange.getAttribute('value')).to.be('1 minute (1m)');
await retry.try(async () => {
const layerCount = await lens.getLayerCount();
expect(layerCount).to.be(1);
Expand Down