[Security Solution] GenAI API Integration Tests#176357
Merged
stephmilovic merged 10 commits intoelastic:mainfrom Feb 7, 2024
Merged
[Security Solution] GenAI API Integration Tests#176357stephmilovic merged 10 commits intoelastic:mainfrom
stephmilovic merged 10 commits intoelastic:mainfrom
Conversation
stephmilovic
added
release_note:skip
stephmilovic
commented
Feb 7, 2024
| export default createTestConfig({ | ||
| kbnTestServerArgs: [ | ||
| // used for connector simulators | ||
| `--xpack.actions.proxyUrl=http://localhost:6200`, |
Contributor
Author
There was a problem hiding this comment.
Idk that I can use get-port here. I'm wondering if @YulNaumenko can speak to the importance of the dynamic port number here as I see your name in the git blame from the spot I stole this code from (x-pack/test/alerting_api_integration/common/config.ts) https://github.com/elastic/kibana/pull/75232/files#diff-1477d89e2965e56261180479a84bfb0e762793a73b88baa29300a7ed023d0f28R61-R62
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 8, 2024
dgieselaar
added a commit
that referenced
this pull request
Feb 13, 2024
## Summary This adds functionality to allow consumers of the AI Assistant for Observability to add context to the LLM conversation, at the start of a conversation and contextual after every prompt. https://github.com/elastic/kibana/assets/535564/b4d62897-d701-4c23-b90b-464cad21e9d0  ## How to use The service now exposes a `setApplicationContext` function, that returns a hook to unregister the context. Here's an example: Consumers can use this to add context relevant to the route or settings of Kibana that might be relevant for the LLM within that conversation. Example: ```ts useEffect(() => { return setApplicationContext({ data: [ { name: 'top_transactions', description: 'The visible transaction groups', value: mainStatistics.transactionGroups.map((group) => { return { name: group.name, alertsCount: group.alertsCount, }; }), }, ], }); }, [setApplicationContext, mainStatistics]); ``` By default the URL that the user is currently on is always included in the context so the Assistant will always take that into account. ## Details for reviewers - `recall` function has been renamed to `context` - `context` function now returns both Knowledge base entries as well as chat context that is set by `setApplicationContext`.#176357 - part of the function logic was moved from the ObservabilityAIAssistantService into the ChatFunctionClient, for easier testing --------- Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
CoenWarmer
added a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary This adds functionality to allow consumers of the AI Assistant for Observability to add context to the LLM conversation, at the start of a conversation and contextual after every prompt. https://github.com/elastic/kibana/assets/535564/b4d62897-d701-4c23-b90b-464cad21e9d0  ## How to use The service now exposes a `setApplicationContext` function, that returns a hook to unregister the context. Here's an example: Consumers can use this to add context relevant to the route or settings of Kibana that might be relevant for the LLM within that conversation. Example: ```ts useEffect(() => { return setApplicationContext({ data: [ { name: 'top_transactions', description: 'The visible transaction groups', value: mainStatistics.transactionGroups.map((group) => { return { name: group.name, alertsCount: group.alertsCount, }; }), }, ], }); }, [setApplicationContext, mainStatistics]); ``` By default the URL that the user is currently on is always included in the context so the Assistant will always take that into account. ## Details for reviewers - `recall` function has been renamed to `context` - `context` function now returns both Knowledge base entries as well as chat context that is set by `setApplicationContext`.elastic#176357 - part of the function logic was moved from the ObservabilityAIAssistantService into the ChatFunctionClient, for easier testing --------- Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary This adds functionality to allow consumers of the AI Assistant for Observability to add context to the LLM conversation, at the start of a conversation and contextual after every prompt. https://github.com/elastic/kibana/assets/535564/b4d62897-d701-4c23-b90b-464cad21e9d0  ## How to use The service now exposes a `setApplicationContext` function, that returns a hook to unregister the context. Here's an example: Consumers can use this to add context relevant to the route or settings of Kibana that might be relevant for the LLM within that conversation. Example: ```ts useEffect(() => { return setApplicationContext({ data: [ { name: 'top_transactions', description: 'The visible transaction groups', value: mainStatistics.transactionGroups.map((group) => { return { name: group.name, alertsCount: group.alertsCount, }; }), }, ], }); }, [setApplicationContext, mainStatistics]); ``` By default the URL that the user is currently on is always included in the context so the Assistant will always take that into account. ## Details for reviewers - `recall` function has been renamed to `context` - `context` function now returns both Knowledge base entries as well as chat context that is set by `setApplicationContext`.elastic#176357 - part of the function logic was moved from the ObservabilityAIAssistantService into the ChatFunctionClient, for easier testing --------- Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add API tests for Security GenAI team.
Starting with very basic tests to keep this PR about setting up the GenAI test suite with CODEOWNERS and CI execution. Will follow up with comprehensive tests.