[build] Use build sha instead of build number for CDN assets#176186
Merged
jbudz merged 9 commits intoelastic:mainfrom Feb 9, 2024
Merged
[build] Use build sha instead of build number for CDN assets#176186jbudz merged 9 commits intoelastic:mainfrom
jbudz merged 9 commits intoelastic:mainfrom
Conversation
jbudz
added
Team:Operations
Contributor
Author
|
buildkite test this |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
Author
|
buildkite test this |
Ikuni17
reviewed
Feb 7, 2024
Comment on lines
+26
to
+27
| // TODO: update to buildShaShort after https://github.com/elastic/kibana/pull/175898 | ||
| const buildSha = config.getBuildSha().substring(0, 12); |
Contributor
There was a problem hiding this comment.
Can we update this since the PR is merged?
Ikuni17
approved these changes
Feb 8, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…#176186) elastic#175898 updates routes to cache bust using the build checksum instead of build number. This updates the directory structure of the CDN assets archive accordingly. ``` kibana-8.13.0-SNAPSHOT-cdn-assets └── e96cc06 ├── bundles │ ├── core │ ├── kbn-monaco │ ├── kbn-ui-shared-deps-npm │ ├── kbn-ui-shared-deps-src │ └── plugin └── ui ├── favicons ├── fonts ├── legacy_dark_theme.css ├── legacy_dark_theme.min.css ├── legacy_light_theme.css └── legacy_light_theme.min.css 11 directories, 4 files ```
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…#176186) elastic#175898 updates routes to cache bust using the build checksum instead of build number. This updates the directory structure of the CDN assets archive accordingly. ``` kibana-8.13.0-SNAPSHOT-cdn-assets └── e96cc06 ├── bundles │ ├── core │ ├── kbn-monaco │ ├── kbn-ui-shared-deps-npm │ ├── kbn-ui-shared-deps-src │ └── plugin └── ui ├── favicons ├── fonts ├── legacy_dark_theme.css ├── legacy_dark_theme.min.css ├── legacy_light_theme.css └── legacy_light_theme.min.css 11 directories, 4 files ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#175898 updates routes to cache bust using the build checksum instead of build number. This updates the directory structure of the CDN assets archive accordingly.