Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
bmorelli25
added
the
release_note:skip
jbudz
approved these changes
Jan 26, 2024
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
### Summary The new check added in elastic#175463 is currently failing: <img width="941" alt="Screenshot 2024-01-26 at 7 38 06 AM" src="https://github.com/elastic/kibana/assets/5618806/3d196fbb-e462-42d4-89fe-08191378913e"> I think this needs to point to the `@master` branch instead of `@current`. For example: 1. https://github.com/elastic/stack-docs/blob/main/.github/workflows/docs-preview-links.yml#L15 2. https://github.com/elastic/docs/blob/master/.github/workflows/doc-preview.yml#L17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new check added in #175463 is currently failing:
I think this needs to point to the
@masterbranch instead of@current. For example: