[ES|QL] STATS nested expressions - second part#175515
Merged
dej611 merged 8 commits intoelastic:mainfrom Jan 29, 2024
Merged
Conversation
dej611
added
Team:Visualizations
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
|
/ci |
stratoula
approved these changes
Jan 29, 2024
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
This works great! LGTM! I think it would also make sense to suggest eval functions inside aggs (except from the fields) here too.
So for example
from logstash-* | stats meow = avg(round(bytes))
typing ro here would suggest round etc...
Wdyt Marco?
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
Ok, I'll prepare a follow up with that. |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary This is the second part of elastic#175288 where nested expressions are supported in STATS scope as well. I've tweaked the previous test suite here to check all agg functions with nested expressions in various scenarios. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary This is the second part of elastic#175288 where nested expressions are supported in STATS scope as well. I've tweaked the previous test suite here to check all agg functions with nested expressions in various scenarios. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the second part of #175288 where nested expressions are supported in STATS scope as well.
I've tweaked the previous test suite here to check all agg functions with nested expressions in various scenarios.
Checklist