Lock package manager version #175495
Merged
Lock package manager version #175495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
Contributor
Author
|
Signed! |
stephmilovic
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
reviewed
Jan 25, 2024
Member
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
One nit, thanks for opening this.
Co-authored-by: Jon <[email protected]>
Member
|
buildkite test this |
Member
|
@elasticmachine run elasticsearch-ci/docs |
jbudz
approved these changes
Jan 25, 2024
jbudz
added
the
backport:all-open
jbudz
reviewed
Jan 25, 2024
package.json
Outdated
| "yarn-deduplicate": "^6.0.2" | ||
| } | ||
| }, | ||
| "packageManager": "^[email protected]" |
Member
There was a problem hiding this comment.
Apologies, it looks like I was mistaken and the ^ is not used. We're running 1.22.21 on CI, do you mind if we update the versions to 1.22.21 and remove the ^?
Contributor
Author
There was a problem hiding this comment.
Not at all! I can do it too
Member
|
buildkite test this |
Member
|
@elasticmachine run elasticsearch-ci/docs |
Member
|
buildkite test this |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 25, 2024
In addition to elastic#175495 (cherry picked from commit 81ae390)
jbudz
reviewed
Jan 25, 2024
package.json
Outdated
Comment on lines
1688
to
1689
| "packageManager": "[email protected]" | ||
| } |
Member
There was a problem hiding this comment.
Sorry for all the issues! I think this is the last one - bootstrap is removing the trailing newline here and we have a modified files check that's failing. Can we remove the newline?
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Jan 25, 2024
kibanamachine
referenced
this pull request
Jan 25, 2024
# Backport This will backport the following commits from `main` to `8.12`: - [Upgrade yarn to 1.22.21 in WORKSPACE.bazel (#175632)](#175632) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-25T20:39:36Z","message":"Upgrade yarn to 1.22.21 in WORKSPACE.bazel (#175632)\n\nIn addition to https://github.com/elastic/kibana/pull/175495","sha":"81ae390daad7e3e19fb3b78bbb153e91869a27dd","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.13.0"],"title":"Upgrade yarn to 1.22.21 in WORKSPACE.bazel","number":175632,"url":"https://github.com/elastic/kibana/pull/175632","mergeCommit":{"message":"Upgrade yarn to 1.22.21 in WORKSPACE.bazel (#175632)\n\nIn addition to https://github.com/elastic/kibana/pull/175495","sha":"81ae390daad7e3e19fb3b78bbb153e91869a27dd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175632","number":175632,"mergeCommit":{"message":"Upgrade yarn to 1.22.21 in WORKSPACE.bazel (#175632)\n\nIn addition to https://github.com/elastic/kibana/pull/175495","sha":"81ae390daad7e3e19fb3b78bbb153e91869a27dd"}}]}] BACKPORT--> Co-authored-by: Jon <[email protected]>
Member
|
buildkite test this |
Member
|
buildkite test this |
Member
|
@elasticmachine run elasticsearch-ci/docs |
Member
|
buildkite test this |
Member
|
@elasticmachine run elasticsearch-ci/docs |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
|
Thank you @jacoblee93 |
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Jan 26, 2024
I believe the intention was to restrict the `yarn` version to `1.22.19`, but the current `package.json` setup does not enforce it. This config change should do it. None. None. - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Jon <[email protected]> Co-authored-by: Jon <[email protected]>
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Jan 26, 2024
I believe the intention was to restrict the `yarn` version to `1.22.19`, but the current `package.json` setup does not enforce it. This config change should do it. None. None. - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Jon <[email protected]> Co-authored-by: Jon <[email protected]>
This was referenced Jan 26, 2024
jbudz
added a commit
that referenced
this pull request
Jan 29, 2024
#175495 Co-authored-by: Jacob Lee <[email protected]>
jbudz
added a commit
that referenced
this pull request
Jan 29, 2024
#175495 --------- Co-authored-by: Jacob Lee <[email protected]>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary I believe the intention was to restrict the `yarn` version to `1.22.19`, but the current `package.json` setup does not enforce it. This config change should do it. ### Checklist None. ### Risk Matrix None. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Jon <[email protected]> Co-authored-by: Jon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I believe the intention was to restrict the
yarnversion to1.22.19, but the currentpackage.jsonsetup does not enforce it. This config change should do it.Checklist
None.
Risk Matrix
None.
For maintainers