-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Ftrs restructure files #175417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Ftrs restructure files #175417
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
82d702c
moved all files under domain followed by license
yctercero 90f8f32
updated buildkite ftr configs yml
yctercero ff0fffc
update codeowners
yctercero 86ebfe2
modifying scripts
yctercero d78549b
Merge branch 'main' of github.com:elastic/kibana into ftrs-restructur…
yctercero 893c7df
Merge branch 'main' of github.com:elastic/kibana into ftrs-restructur…
yctercero 08864b5
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 0fc1744
fix script, lint errors + add missing tests to qa
WafaaNasr 53e8d72
Merge branch 'main' into ftrs-restructure-files
WafaaNasr 6aebcb6
Merge branch 'main' into ftrs-restructure-files
yctercero 71ccb7d
Merge branch 'main' of github.com:elastic/kibana into ftrs-restructur…
yctercero ce990eb
PR feedback
yctercero 52d8b12
needed to modify a few mroe files after changing where rule_creante, …
yctercero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to block, makes more sense as a follow up for the whole file:
It looks like we don't have any retries for spot instance preemptions. The exit status is
-1in that case. Depending on stability requirements we can swap out spot instances or add retries.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MadameSheema any feedback on what the suggested value is?