Skip to content

[Security Solution] Use current user instead of internal user when querying for threshold rule history#174723

Merged
marshallmain merged 4 commits intoelastic:mainfrom
marshallmain:threshold-history-current-user-fix
Jan 22, 2024
Merged

[Security Solution] Use current user instead of internal user when querying for threshold rule history#174723
marshallmain merged 4 commits intoelastic:mainfrom
marshallmain:threshold-history-current-user-fix

Conversation

@marshallmain
Copy link
Copy Markdown
Contributor

@marshallmain marshallmain commented Jan 11, 2024

Summary

Follow up to #174216

@marshallmain marshallmain marked this pull request as ready for review January 12, 2024 00:06
@marshallmain marshallmain requested a review from a team as a code owner January 12, 2024 00:06
wrapSequences,
listClient,
ruleDataReader: ruleDataClient.getReader({ namespace: options.spaceId }),
ruleDataClient,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #8 / migration v2 clean ups if migration fails

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@marshallmain marshallmain added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Jan 22, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@marshallmain marshallmain merged commit f87a348 into elastic:main Jan 22, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 22, 2024
…erying for threshold rule history (elastic#174723)

## Summary

Follow up to elastic#174216

(cherry picked from commit f87a348)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 22, 2024
…when querying for threshold rule history (#174723) (#175270)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Security Solution] Use current user instead of internal user when
querying for threshold rule history
(#174723)](#174723)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marshall
Main","email":"55718608+marshallmain@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-22T21:22:07Z","message":"[Security
Solution] Use current user instead of internal user when querying for
threshold rule history (#174723)\n\n## Summary\r\n\r\nFollow up to
https://github.com/elastic/kibana/pull/174216","sha":"f87a34838659fed1bd22f21f9de0bc1162ae917b","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Engine","v8.12.1","v8.13.0"],"title":"[Security Solution] Use current
user instead of internal user when querying for threshold rule
history","number":174723,"url":"https://github.com/elastic/kibana/pull/174723","mergeCommit":{"message":"[Security
Solution] Use current user instead of internal user when querying for
threshold rule history (#174723)\n\n## Summary\r\n\r\nFollow up to
https://github.com/elastic/kibana/pull/174216","sha":"f87a34838659fed1bd22f21f9de0bc1162ae917b"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174723","number":174723,"mergeCommit":{"message":"[Security
Solution] Use current user instead of internal user when querying for
threshold rule history (#174723)\n\n## Summary\r\n\r\nFollow up to
https://github.com/elastic/kibana/pull/174216","sha":"f87a34838659fed1bd22f21f9de0bc1162ae917b"}}]}]
BACKPORT-->

Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@marshallmain marshallmain deleted the threshold-history-current-user-fix branch April 4, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.1 v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants