Skip to content

[Security Solution][Entity Analytics] Adding Context information in Risk Summary#174574

Merged
tiansivive merged 11 commits intoelastic:mainfrom
tiansivive:siem-ea-8359
Jan 16, 2024
Merged

[Security Solution][Entity Analytics] Adding Context information in Risk Summary#174574
tiansivive merged 11 commits intoelastic:mainfrom
tiansivive:siem-ea-8359

Conversation

@tiansivive
Copy link
Contributor

@tiansivive tiansivive commented Jan 10, 2024

Adding context in Risk Summary, part of #8207 Meta
This PR handles both #8357 and #8359

Screenshot 2024-01-10 at 12 06 00

Closing #174443 since this PR includes those changes as well

@tiansivive tiansivive added release_note:fix release_note:feature Makes this part of the condensed release notes 8.13 candidate Team:Entity Analytics Security Entity Analytics Team labels Jan 10, 2024
@tiansivive tiansivive requested a review from a team as a code owner January 10, 2024 10:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@tiansivive
Copy link
Contributor Author

@nkhristinin This is the updated PR after our discussion regarding the score fields.
I took a new screenshot so I think now these are the correct values.

@SourinPaul and @jaredburgettelastic
As discussed previously, for now I've rounded all fields to 2 decimal cases. That seems like the best way to present this data but do let me know if we need to alter this logic.

@tiansivive
Copy link
Contributor Author

@elasticmachine merge upstream

@tiansivive tiansivive requested a review from a team as a code owner January 15, 2024 15:41
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4871 4872 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.4MB 11.4MB +431.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tiansivive

Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀
The code LGTM and also desk tested it.

Btw, those two decimals in the risk score look weird =/

@tiansivive tiansivive merged commit b1e8379 into elastic:main Jan 16, 2024
@kibanamachine kibanamachine added v8.13.0 backport:skip This PR does not require backporting labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.13 candidate backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes release_note:fix Team:Entity Analytics Security Entity Analytics Team v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants