Skip to content

[8.12] [Security Solution] Adds tests for coverage overview page (#168058)#174549

Merged
dplumlee merged 3 commits intoelastic:8.12from
dplumlee:backport/8.12/pr-168058
Jan 10, 2024
Merged

[8.12] [Security Solution] Adds tests for coverage overview page (#168058)#174549
dplumlee merged 3 commits intoelastic:8.12from
dplumlee:backport/8.12/pr-168058

Conversation

@dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Jan 9, 2024

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

…8058)

**Resolves: elastic#162250

Adds remaining unit, api integration, and e2e cypress tests for the
coverage overview page in accordance to the [existing test
plan](https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/rule_management/coverage_overview_dashboard.md)

- [Flaky test runner
build](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4756)

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 315cf9d)
@dplumlee dplumlee added the backport This PR is a backport of another PR label Jan 9, 2024
@dplumlee dplumlee enabled auto-merge (squash) January 9, 2024 19:53
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a side-by-side comparison with the OG PR just so there'd be a second set of 👀's. Please check out my comments to make sure they validate against the merge conflicts you resolved, but everything else looked 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport note: This file includes a move and was deleted in original PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.1MB 13.1MB +12.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dplumlee dplumlee merged commit 8233fd0 into elastic:8.12 Jan 10, 2024
@dplumlee dplumlee deleted the backport/8.12/pr-168058 branch January 10, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants