Upgrade EUI to v92.0.0 by cee-chen · Pull Request #174487 · elastic/kibana

cee-chen · 2024-01-08T20:01:41Z

v91.3.1⏩v92.0.0-backport.0

`v92.0.0-backport.0`

This is a backport release only intended for use by Kibana.

Bug fixes

Fixed an EuiTreeView JSX Typescript error (#7452)
Fixed a color console warning being generated by disabled EuiSteps (#7454)

`v92.0.0`

Updated generic types of EuiBasicTable, EuiInMemoryTable and EuiSearchBar.Query.execute to add extends object constraint (#7340)
- This change should have no impact on your applications since the updated types only affect properties that exclusively accept object values.
Added a new EuiFlyoutResizable component (#7439)
Updated EuiTextArea to accept isClearable and icon as props (#7449)

Bug fixes

EuiRange/EuiDualRange's track ticks & highlights now update their positions on resize (#7442)

Deprecations

Updated EuiFilterButton to remove the second .euiFilterButton__textShift span wrapper. Target .euiFilterButton__text instead (#7444)

Breaking changes

Removed deprecated EuiNotificationEvent. We recommend copying the component to your application if necessary (#7434)
Removed deprecated EuiControlBar. We recommend using EuiBottomBar instead (#7435)

+ backport

- removed in EUI, and no longer needed, as range components now contain their own resize observer and update automatically on width changes

…stead of objects

cee-chen · 2024-01-09T23:48:36Z

...ty_solution/public/detection_engine/rule_creation_ui/components/risk_score_mapping/index.tsx

-          // TODO: https://github.com/elastic/kibana/issues/161456
-          // The About step page contains EuiRange component which does not work properly within memoized parents.
-          // EUI team suggested not to memoize EuiRange/EuiDualRange: https://github.com/elastic/eui/issues/6846
-          // Workaround: We force EuiRange re-rendering by removing/adding it into the DOM.
-          // NOTE: We should remove this workaround once EUI team fixed EuiRange.
-          // Related ticket: https://github.com/elastic/kibana/issues/160561
-        }
-        {isActive && (
-          <EuiFormRow


@e40pud I tested this locally and it appears to be working for me, but would super appreciate a second confirmation/QA! ✨

Tested locally. There is no issue anymore! Thanks for fixing this!!

elasticmachine · 2024-01-09T23:48:42Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

cee-chen · 2024-01-09T23:49:36Z

src/plugins/controls/public/time_slider/components/time_slider.tsx

-  const rangeRef = useRef<EuiDualRangeRef>(null);
-
-  const onPanelResize = (width: number) => {
-    rangeRef.current?.onResize(width);
-  };


This ref and method call were removed because EuiDualRange now contains its own resize observer and automatically adjusts its width accordingly.

PhilippeOberti

changes LGTM for the Protections Experience team!

Heenawter

EUI-provided resize observer works great for the time slider 🎉 Thanks for that change!

mattkime

code changes lgtm

opauloh

Cloud Security Posture changes LGTM

smith

APM/Synthetics/Uptime changes look good.

peteharverson

ML code changes LGTM

e40pud

DE changes LGTM

e40pud · 2024-01-10T13:03:20Z

...ty_solution/public/detection_engine/rule_creation_ui/components/risk_score_mapping/index.tsx

-          // TODO: https://github.com/elastic/kibana/issues/161456
-          // The About step page contains EuiRange component which does not work properly within memoized parents.
-          // EUI team suggested not to memoize EuiRange/EuiDualRange: https://github.com/elastic/eui/issues/6846
-          // Workaround: We force EuiRange re-rendering by removing/adding it into the DOM.
-          // NOTE: We should remove this workaround once EUI team fixed EuiRange.
-          // Related ticket: https://github.com/elastic/kibana/issues/160561
-        }
-        {isActive && (
-          <EuiFormRow


Tested locally. There is no issue anymore! Thanks for fixing this!!

Ikuni17

OPs changes lgtm

efegurkan

Enterprise Search LGTM. Code review only

rylnd

Changes to Entity Analytics look good to me; they're identical in nature to the ones in Detection Engine (which were already approved by @e40pud ) 👍

kibana-ci · 2024-01-10T19:38:45Z

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

[job] [logs] Investigations - Security Solution Cypress Tests #2 / Basic esql search and filter operations "before each" hook for "should change the timerange to ~ 15 minutes ago when back is pressed after modifying timerange to Jan 18, 2023 @ 20:33:29.186 without saving" "before each" hook for "should change the timerange to ~ 15 minutes ago when back is pressed after modifying timerange to Jan 18, 2023 @ 20:33:29.186 without saving"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	445.1KB	445.1KB	-5.0B
`controls`	199.5KB	199.4KB	-144.0B
`discover`	556.3KB	556.3KB	-4.0B
`lens`	1.4MB	1.4MB	-4.0B
`securitySolution`	11.4MB	11.4MB	-95.0B
total			-252.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	377.9KB	375.2KB	-2.7KB
`kbnUiSharedDeps-css`	258.0KB	250.4KB	-7.6KB
`kbnUiSharedDeps-npmDll`	6.2MB	6.2MB	-11.2KB
`kbnUiSharedDeps-srcJs`	2.3MB	2.3MB	-1.0B
total			-21.5KB

History

💛 Build #186698 was flaky 0149a4d
💛 Build #186615 was flaky 621cb79f45db71d17a0b1caf3d76b4e3b30239d3
💛 Build #186507 was flaky c4fb12a9e36f4a95fce27a35f44b0d8934e4b7d3
💔 Build #186503 failed 8cdad051de8a6e4190d4ed8fb68d4a4c418eb08d
💔 Build #186501 failed 4002ffe15cb126e2ceff15d3d65a92eedc76e79a
💔 Build #186496 failed 70007c1fc2e0f45e5d80fddabbfbe13fe8a5f75e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

`v91.3.1`⏩`v92.0.0-backport.0` --- ## [`v92.0.0-backport.0`](https://github.com/elastic/eui/releases/v92.0.0-backport.0) **This is a backport release only intended for use by Kibana.** **Bug fixes** - Fixed an `EuiTreeView` JSX Typescript error ([elastic#7452](elastic/eui#7452)) - Fixed a color console warning being generated by disabled `EuiStep`s ([elastic#7454](elastic/eui#7454)) ## [`v92.0.0`](https://github.com/elastic/eui/releases/v92.0.0) - Updated generic types of `EuiBasicTable`, `EuiInMemoryTable` and `EuiSearchBar.Query.execute` to add `extends object` constraint ([elastic#7340](elastic/eui#7340)) - This change should have no impact on your applications since the updated types only affect properties that exclusively accept object values. - Added a new `EuiFlyoutResizable` component ([elastic#7439](elastic/eui#7439)) - Updated `EuiTextArea` to accept `isClearable` and `icon` as props ([elastic#7449](elastic/eui#7449)) **Bug fixes** - `EuiRange`/`EuiDualRange`'s track ticks & highlights now update their positions on resize ([elastic#7442](elastic/eui#7442)) **Deprecations** - Updated `EuiFilterButton` to remove the second `.euiFilterButton__textShift` span wrapper. Target `.euiFilterButton__text` instead ([elastic#7444](elastic/eui#7444)) **Breaking changes** - Removed deprecated `EuiNotificationEvent`. We recommend copying the component to your application if necessary ([elastic#7434](elastic/eui#7434)) - Removed deprecated `EuiControlBar`. We recommend using `EuiBottomBar` instead ([elastic#7435](elastic/eui#7435))

kpatticha

APM code changes LGTM. I didn't check for UI regressions though

cee-chen force-pushed the eui-v92.0.0 branch 8 times, most recently from 8cdad05 to c4fb12a Compare January 9, 2024 03:03

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.13.0 labels Jan 9, 2024

cee-chen force-pushed the eui-v92.0.0 branch from c4fb12a to 621cb79 Compare January 9, 2024 16:18

cee-chen added 8 commits January 9, 2024 14:26

Upgrade EUI to v92.0.0

08408bf

+ backport

i18n updates

d265e07

[EuiFilterButton] Update classNames to account for EUI DOM/CSS changes

f4186b3

[EuiFilterButton] Snapshot updates

c2a83c8

[EuiRange][Security] Remove now-unnecessary workaround within about step

f16ed50

[EuiDualRange] Remove usage of deprecated onResize ref method

cff9b40

- removed in EUI, and no longer needed, as range components now contain their own resize observer and update automatically on width changes

[EuiInMemoryTable][EuiBasicTable] extends object type updates

9b62f1b

[EuiInMemoryTable][EuiBasicTable] TS skip tables that pass strings in…

0149a4d

…stead of objects

cee-chen force-pushed the eui-v92.0.0 branch from 621cb79 to 0149a4d Compare January 9, 2024 22:26

cee-chen marked this pull request as ready for review January 9, 2024 23:47

cee-chen requested review from a team as code owners January 9, 2024 23:47

cee-chen requested a review from a team January 9, 2024 23:47

cee-chen requested review from a team as code owners January 9, 2024 23:47

cee-chen commented Jan 9, 2024

View reviewed changes

botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Jan 9, 2024

cee-chen commented Jan 9, 2024

View reviewed changes

PhilippeOberti approved these changes Jan 9, 2024

View reviewed changes

Heenawter self-requested a review January 9, 2024 23:57

Heenawter approved these changes Jan 10, 2024

View reviewed changes

mattkime approved these changes Jan 10, 2024

View reviewed changes

opauloh approved these changes Jan 10, 2024

View reviewed changes

smith approved these changes Jan 10, 2024

View reviewed changes

pgayvallet approved these changes Jan 10, 2024

View reviewed changes

cnasikas approved these changes Jan 10, 2024

View reviewed changes

peteharverson approved these changes Jan 10, 2024

View reviewed changes

sabarasaba approved these changes Jan 10, 2024

View reviewed changes

e40pud approved these changes Jan 10, 2024

View reviewed changes

e40pud mentioned this pull request Jan 10, 2024

[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page #161456

Closed

Ikuni17 approved these changes Jan 10, 2024

View reviewed changes

efegurkan approved these changes Jan 10, 2024

View reviewed changes

Merge branch 'main' into eui-v92.0.0

11a9924

cee-chen enabled auto-merge (squash) January 10, 2024 17:12

rylnd approved these changes Jan 10, 2024

View reviewed changes

cee-chen merged commit 517763e into elastic:main Jan 10, 2024

cee-chen deleted the eui-v92.0.0 branch January 10, 2024 19:38

kibanamachine added the backport:skip This PR does not require backporting label Jan 10, 2024

kertal mentioned this pull request Jan 12, 2024

[UnifiedDocViewer] Apply push flyout style #163798

Closed

kpatticha reviewed Jan 15, 2024

View reviewed changes

Heenawter mentioned this pull request Jan 16, 2024

[Controls] Options list control selections are centered #174971

Closed

Comments

Conversation

cee-chen commented Jan 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v92.0.0-backport.0

v92.0.0

Uh oh!

cee-chen Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

e40pud Jan 10, 2024

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jan 9, 2024

Uh oh!

cee-chen Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

PhilippeOberti left a comment

Choose a reason for hiding this comment

Uh oh!

Heenawter left a comment

Choose a reason for hiding this comment

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

opauloh left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

e40pud left a comment

Choose a reason for hiding this comment

Uh oh!

e40pud Jan 10, 2024

Choose a reason for hiding this comment

Uh oh!

Ikuni17 left a comment

Choose a reason for hiding this comment

Uh oh!

efegurkan left a comment

Choose a reason for hiding this comment

Uh oh!

rylnd left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jan 10, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

kpatticha left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

cee-chen commented Jan 8, 2024 •

edited

Loading

`v92.0.0-backport.0`

`v92.0.0`