[Ops] Work around unit-tests in watch mode fails to set 'structuredClone' #174444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
pheyos
approved these changes
Jan 8, 2024
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Jan 11, 2024
…one' (elastic#174444) ## Summary @CoenWarmer found that `--watch` on jest tests will cause this sort of error: ``` TypeError: Cannot assign to read only property 'structuredClone' of object '[object global]' ``` There's some workaround suggested on this thread (although not necessarily related): zloirock/core-js#1281 In the workaround, we set `structuredClone` to `{}`, this would allow the currently offending 3rd party to overwrite it where it's currently getting an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@CoenWarmer found that
--watchon jest tests will cause this sort of error:There's some workaround suggested on this thread (although not necessarily related): zloirock/core-js#1281
In the workaround, we set
structuredCloneto{}, this would allow the currently offending 3rd party to overwrite it where it's currently getting an error.