Skip to content

[ci] Avoid unintended notifications on failing test comment #174124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 3, 2024
Merged

[ci] Avoid unintended notifications on failing test comment #174124

merged 6 commits into from
Jan 3, 2024

Conversation

@jbudz
Copy link
Member

@jbudz jbudz commented Jan 2, 2024 •
edited by kibanamachine
Loading

null

@jbudz jbudz added Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Jan 2, 2024
@jbudz
Copy link
Member Author

jbudz commented Jan 2, 2024

buildkite test this

jbudz
jbudz commented Jan 2, 2024
View reviewed changes
@jbudz
Copy link
Member Author

jbudz commented Jan 3, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Jan 3, 2024

image

@jbudz
Revert "test"
528ecb2 
This reverts commit b87ada0.
@jbudz jbudz marked this pull request as ready for review January 3, 2024 01:10
@jbudz jbudz requested a review from a team as a code owner January 3, 2024 01:10
@jbudz
Copy link
Member Author

jbudz commented Jan 3, 2024

buildkite test this

@kibana-ci
Copy link

kibana-ci commented Jan 3, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz added Team:Operations Kibana-Operations Team and removed Team:Operations Kibana-Operations Team labels Jan 3, 2024
@jbudz jbudz merged commit 5951512 into elastic:main Jan 3, 2024
@kibanamachine kibanamachine mentioned this pull request Jan 3, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 3, 2024
@jbudz
[ci] Avoid unintended notifications on failing test comment (elastic#…
396a4b2 
…174124)

(cherry picked from commit 5951512)
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 3, 2024

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Handle content stream errors in report pre-deletion (#173792)
- chore(NA): bump node into v20 (#173461)
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 174124

Questions ?

Please refer to the Backport tool documentation

@jbudz jbudz mentioned this pull request Jan 3, 2024
Merged
kibanamachine added a commit that referenced this pull request Jan 3, 2024
@kibanamachine @jbudz
[8.12] [ci] Avoid unintended notifications on failing test comment (#…
96d1024 
…174124) (#174206)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[ci] Avoid unintended notifications on failing test comment
(#174124)](#174124)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-03T17:52:52Z","message":"[ci]
Avoid unintended notifications on failing test comment
(#174124)","sha":"5951512197d736d575464c4c8839aa1993b878ed","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.13.0"],"title":"[ci]
Avoid unintended notifications on failing test
comment","number":174124,"url":"https://github.com/elastic/kibana/pull/174124","mergeCommit":{"message":"[ci]
Avoid unintended notifications on failing test comment
(#174124)","sha":"5951512197d736d575464c4c8839aa1993b878ed"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174124","number":174124,"mergeCommit":{"message":"[ci]
Avoid unintended notifications on failing test comment
(#174124)","sha":"5951512197d736d575464c4c8839aa1993b878ed"}}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
@jbudz jbudz mentioned this pull request Jan 3, 2024
Merged
jbudz added a commit that referenced this pull request Jan 4, 2024
@jbudz
[7.17] [ci] Avoid unintended notifications on failing test comment (#…
152243f 
…174124) (#174215)

elastic/kibana-buildkite-library@8119df1
#174124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees

No one assigned

Labels

backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.12.0 v8.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbudz @kibana-ci @kibanamachine @Ikuni17