[Enterprise Search] Update name of connector config final step#173366
Merged
leemthompo merged 1 commit intoelastic:mainfrom Dec 14, 2023
Merged
[Enterprise Search] Update name of connector config final step#173366leemthompo merged 1 commit intoelastic:mainfrom
leemthompo merged 1 commit intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
leemthompo
added
release_note:skip
efegurkan
approved these changes
Dec 14, 2023
Member
efegurkan
left a comment
efegurkan
left a comment
There was a problem hiding this comment.
LGTM, with a notice.
This may trigger i18n key changes.
If you didn't please run node scripts/i18n_check.js --fix and add if any changes are introduced. (CI may do it automatically sometimes)
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @leemthompo |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 14, 2023
…ic#173366) Improves existing step name ⬇️  (cherry picked from commit f247b24)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 14, 2023
…#173366) (#173380) # Backport This will backport the following commits from `main` to `8.12`: - [[Enterprise Search] Update name of connector config final step (#173366)](#173366) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Liam Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-12-14T13:11:43Z","message":"[Enterprise Search] Update name of connector config final step (#173366)\n\nImproves existing step name ⬇️ \r\n\r\n","sha":"f247b24cb7ee3c6d89d929e059ef0e672de17c15","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.12.0","v8.13.0"],"number":173366,"url":"https://github.com/elastic/kibana/pull/173366","mergeCommit":{"message":"[Enterprise Search] Update name of connector config final step (#173366)\n\nImproves existing step name ⬇️ \r\n\r\n","sha":"f247b24cb7ee3c6d89d929e059ef0e672de17c15"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173366","number":173366,"mergeCommit":{"message":"[Enterprise Search] Update name of connector config final step (#173366)\n\nImproves existing step name ⬇️ \r\n\r\n","sha":"f247b24cb7ee3c6d89d929e059ef0e672de17c15"}}]}] BACKPORT--> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
leemthompo
added a commit
that referenced
this pull request
Feb 6, 2024
Additional fixes missed in #173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague (cherry picked from commit 87a66f2)
kibanamachine
referenced
this pull request
Feb 6, 2024
# Backport This will backport the following commits from `main` to `8.12`: - [[Ent Search] Connector client copy cleanup (#176290)](#176290) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Liam Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-06T17:31:55Z","message":"[Ent Search] Connector client copy cleanup (#176290)\n\nAdditional fixes missed in https://github.com/elastic/kibana/pull/173366\r\n\r\n- The deployment first paragraph was outdated and irrelevant to the user\r\nworkflow\r\n- Some of step headings were vague","sha":"87a66f24898d9d0ad20b357f62cdc9ea407ad27b","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.13.0","v8.12.2"],"title":"[Ent Search] Connector client copy cleanup","number":176290,"url":"https://github.com/elastic/kibana/pull/176290","mergeCommit":{"message":"[Ent Search] Connector client copy cleanup (#176290)\n\nAdditional fixes missed in https://github.com/elastic/kibana/pull/173366\r\n\r\n- The deployment first paragraph was outdated and irrelevant to the user\r\nworkflow\r\n- Some of step headings were vague","sha":"87a66f24898d9d0ad20b357f62cdc9ea407ad27b"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176290","number":176290,"mergeCommit":{"message":"[Ent Search] Connector client copy cleanup (#176290)\n\nAdditional fixes missed in https://github.com/elastic/kibana/pull/173366\r\n\r\n- The deployment first paragraph was outdated and irrelevant to the user\r\nworkflow\r\n- Some of step headings were vague","sha":"87a66f24898d9d0ad20b357f62cdc9ea407ad27b"}},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves existing step name ⬇️