Skip to content

[8.12] Switch "suggest user profiles" API to internal use (#173141)#173249

Merged
kibanamachine merged 1 commit intoelastic:8.12from
kibanamachine:backport/8.12/pr-173141
Dec 13, 2023
Merged

[8.12] Switch "suggest user profiles" API to internal use (#173141)#173249
kibanamachine merged 1 commit intoelastic:8.12from
kibanamachine:backport/8.12/pr-173141

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

## Summary

With this changes I make "suggestions user profiles" API to be internal
instead of public. We did not reveal it via documentation and it is
better to mark it as an internal API.

This API was introduced in this PR
elastic#170579 and was not released yet.

I also realised that currently the route does not reflect the fact that
it is finding user profiles:

`/api/detection_engine/signals/_find`

The new version will have `users` as part of the path:

`/internal/detection_engine/users/_find`

(cherry picked from commit 7e168c7)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Dec 13, 2023
@kibanamachine kibanamachine enabled auto-merge (squash) December 13, 2023 10:15
@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #76 / discover Discover Saved Queries Manage saved queries updates a saved query

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 66.8KB 66.8KB +6.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@kibanamachine kibanamachine merged commit b1dbf9a into elastic:8.12 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants